From: Jan Kara <jack@suse.cz>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/3 RESEND] Fix hang of BSD accounting on frozen filesystem
Date: Thu, 7 Feb 2013 16:43:06 +0100 [thread overview]
Message-ID: <20130207154306.GB25392@quack.suse.cz> (raw)
In-Reply-To: <CANGUGtABHGUVk8qSJe_Ckh0Sb7WEiyCVDEdzf2N+rESHM7t3bw@mail.gmail.com>
Hi,
On Thu 07-02-13 16:32:22, Marco Stornelli wrote:
> 2013/2/7 Jan Kara <jack@suse.cz>:
> > I'm trying to push this series to you for several months already but I
> > didn't get a word from you... This is a third resend or so. Can you
> > please share your opinion or merge it? Thanks! There is actually a user
> > who hit the deadlock...
>
> it's actually out of scope about this patch series, but what do you
> think about to change the freeze wait queue from uninterruptible to
> killable? I think it should be worth but I don't know if it can break
> user-space apps.
I wasn't considering it but it should be doable with a relatively low
effort (most callers use mnt_want_write() anyway and that has to already
deal with failure). I'm not sure when I get to it though.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2013-02-07 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 14:52 [PATCH 0/3 RESEND] Fix hang of BSD accounting on frozen filesystem Jan Kara
2013-02-07 14:52 ` [PATCH 1/3] fs: Return EAGAIN when O_NONBLOCK write should block on frozen fs Jan Kara
2013-02-07 14:52 ` [PATCH 2/3] fs: Fix hang with BSD accounting on frozen filesystem Jan Kara
2013-02-07 14:52 ` [PATCH 3/3] ocfs2: Add freeze protection to ocfs2_file_splice_write() Jan Kara
2013-02-07 17:33 ` Joel Becker
2013-02-07 15:32 ` [PATCH 0/3 RESEND] Fix hang of BSD accounting on frozen filesystem Marco Stornelli
2013-02-07 15:43 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130207154306.GB25392@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).