From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: [PATCH 3/3] ocfs2: Add freeze protection to ocfs2_file_splice_write() Date: Thu, 7 Feb 2013 09:33:49 -0800 Message-ID: <20130207173348.GA29575@localhost> References: <1360248739-24836-1-git-send-email-jack@suse.cz> <1360248739-24836-4-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com To: Jan Kara Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:51029 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755989Ab3BGRdz (ORCPT ); Thu, 7 Feb 2013 12:33:55 -0500 Content-Disposition: inline In-Reply-To: <1360248739-24836-4-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Feb 07, 2013 at 03:52:19PM +0100, Jan Kara wrote: > ocfs2_file_splice_write() was missed when adding freeze protection to all > write paths. Fix that. > > CC: Joel Becker > CC: ocfs2-devel@oss.oracle.com > Signed-off-by: Jan Kara Acked-by: Joel Becker > --- > fs/ocfs2/file.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index 3898499..1f6916c 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -2468,6 +2468,9 @@ static ssize_t ocfs2_file_splice_write(struct pipe_inode_info *pipe, > out->f_path.dentry->d_name.len, > out->f_path.dentry->d_name.name, len); > > + if (!sb_start_file_write(out)) > + return -EAGAIN; > + > if (pipe->inode) > mutex_lock_nested(&pipe->inode->i_mutex, I_MUTEX_PARENT); > > @@ -2506,6 +2509,7 @@ static ssize_t ocfs2_file_splice_write(struct pipe_inode_info *pipe, > > balance_dirty_pages_ratelimited(mapping); > } > + sb_end_write(inode->i_sb); > > return ret; > } > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- "Ninety feet between bases is perhaps as close as man has ever come to perfection." - Red Smith http://www.jlbec.org/ jlbec@evilplan.org