From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 1/2] vfs: make fcheck_files() an exported functions
Date: Sat, 9 Feb 2013 11:24:47 -0800
Message-ID: <20130209192447.GE2875@htj.dyndns.org>
References: <20130109170105.GM3926@htj.dyndns.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>, chavey@google.com,
	Andrew Morton <akpm@linux-foundation.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-pa0-f46.google.com ([209.85.220.46]:62790 "EHLO
	mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758494Ab3BITYy (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 9 Feb 2013 14:24:54 -0500
Received: by mail-pa0-f46.google.com with SMTP id kp14so2545387pab.19
        for <linux-fsdevel@vger.kernel.org>; Sat, 09 Feb 2013 11:24:53 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20130109170105.GM3926@htj.dyndns.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

(cc'ing Andrew)

On Wed, Jan 09, 2013 at 09:01:05AM -0800, Tejun Heo wrote:
> We want to add a trace point to fcheck_files() but macros and inline
> functions defined in header files can't have tracing points.  Move
> fcheck_files() to fs/file.c and make it a proper function.
> 
> A lot of high-frequency fcheck*() users are inside fs/file.c, and, to
> reduce the effect of this change, the new exported function is also
> declared inline.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> ---
> These two patches add vfs_fcheck tracepoint.  Making fcheck_files() a
> function isn't optimal but given the tracepoint restriction I can't
> think of a better way.  The TP is currently in use in google to allow
> ioblame to track who's accessing which file which in turn is used to
> approximately associate IOs with files.  I'm working to upstream the
> rest of ioblame.

Andrew, can you please pick up these two patches?  They were posted a
month ago and at least nobody seems violently against them.  The
original patches are,

 http://article.gmane.org/gmane.linux.file-systems/70591/raw
 http://article.gmane.org/gmane.linux.file-systems/70592/raw

Thanks.

-- 
tejun