From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tejun Heo <tj@kernel.org>
Cc: linux-fsdevel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
chavey@google.com, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] vfs: make fcheck_files() an exported functions
Date: Sun, 10 Feb 2013 00:18:12 +0000 [thread overview]
Message-ID: <20130210001811.GH4503@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20130209192447.GE2875@htj.dyndns.org>
On Sat, Feb 09, 2013 at 11:24:47AM -0800, Tejun Heo wrote:
> (cc'ing Andrew)
>
> On Wed, Jan 09, 2013 at 09:01:05AM -0800, Tejun Heo wrote:
> > We want to add a trace point to fcheck_files() but macros and inline
> > functions defined in header files can't have tracing points. Move
> > fcheck_files() to fs/file.c and make it a proper function.
> >
> > A lot of high-frequency fcheck*() users are inside fs/file.c, and, to
> > reduce the effect of this change, the new exported function is also
> > declared inline.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Cc: Al Viro <viro@zeniv.linux.org.uk>
> > ---
> > These two patches add vfs_fcheck tracepoint. Making fcheck_files() a
> > function isn't optimal but given the tracepoint restriction I can't
> > think of a better way. The TP is currently in use in google to allow
> > ioblame to track who's accessing which file which in turn is used to
> > approximately associate IOs with files. I'm working to upstream the
> > rest of ioblame.
>
> Andrew, can you please pick up these two patches? They were posted a
> month ago and at least nobody seems violently against them. The
> original patches are,
Consider *any* tracepoints in that area blanketly NAKed. Sorry, I thought
I made it clear, but just in case:
As far as I'm concerned, *the* *only* interface stability warranties in VFS
are those for syscalls. Which means that no tracepoints are going to be
acceptable there. End of story.
next prev parent reply other threads:[~2013-02-10 0:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 17:01 [PATCH 1/2] vfs: make fcheck_files() an exported functions Tejun Heo
2013-01-09 17:01 ` [PATCH 2/2] vfs: add fcheck tracepoint Tejun Heo
2013-02-09 19:24 ` [PATCH 1/2] vfs: make fcheck_files() an exported functions Tejun Heo
2013-02-10 0:18 ` Al Viro [this message]
2013-02-12 17:41 ` Tejun Heo
2013-02-12 18:21 ` Steven Rostedt
2013-02-12 20:21 ` Steven Rostedt
2013-02-12 20:44 ` Al Viro
2013-02-12 20:57 ` Steven Rostedt
2013-02-12 20:43 ` Al Viro
2013-02-12 21:03 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130210001811.GH4503@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=chavey@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).