From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 1/2] vfs: make fcheck_files() an exported functions Date: Tue, 12 Feb 2013 09:41:52 -0800 Message-ID: <20130212174152.GH7348@htj.dyndns.org> References: <20130109170105.GM3926@htj.dyndns.org> <20130209192447.GE2875@htj.dyndns.org> <20130210001811.GH4503@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Steven Rostedt , chavey@google.com, Andrew Morton To: Al Viro Return-path: Received: from mail-pa0-f47.google.com ([209.85.220.47]:42506 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932151Ab3BLRl5 (ORCPT ); Tue, 12 Feb 2013 12:41:57 -0500 Received: by mail-pa0-f47.google.com with SMTP id bj3so203239pad.20 for ; Tue, 12 Feb 2013 09:41:56 -0800 (PST) Content-Disposition: inline In-Reply-To: <20130210001811.GH4503@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hey, Al. On Sun, Feb 10, 2013 at 12:18:12AM +0000, Al Viro wrote: > > Andrew, can you please pick up these two patches? They were posted a > > month ago and at least nobody seems violently against them. The > > original patches are, > > Consider *any* tracepoints in that area blanketly NAKed. Sorry, I thought > I made it clear, but just in case: Heh, this is the first time I hear about it. > As far as I'm concerned, *the* *only* interface stability warranties in VFS > are those for syscalls. Which means that no tracepoints are going to be > acceptable there. End of story. I see, it's about API stability. This TP is expected to be used by internal tracer to approxmiately match generated IOs to specific files, so at least the proposed usage is inside the kernel. I suppose there's no way to mark TPs internal, Steven? Anyways, I haven't looked at the tracer code for a while, and am not sure whether the information can be acquired differently. Will take another look. Thanks. -- tejun