From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH review 09/16] xfs: Modify xfs_qm_vop_dqalloc to take kuids, kgids, and kprojids. Date: Tue, 19 Feb 2013 12:57:01 +1100 Message-ID: <20130219015701.GK26694@dastard> References: <87txpaph4n.fsf@xmission.com> <1361149870-27732-1-git-send-email-ebiederm@xmission.com> <1361149870-27732-9-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Alex Elder , Linux Containers , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Myers , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Eric W. Biederman" Return-path: Content-Disposition: inline In-Reply-To: <1361149870-27732-9-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Sun, Feb 17, 2013 at 05:11:02PM -0800, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > Cc: Ben Myers > Cc: Alex Elder > Cc: Dave Chinner > Signed-off-by: "Eric W. Biederman" > --- > fs/xfs/xfs_qm.c | 6 +++--- > fs/xfs/xfs_quota.h | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c > index 6fce3d3..80b8c81 100644 > --- a/fs/xfs/xfs_qm.c > +++ b/fs/xfs/xfs_qm.c > @@ -1617,9 +1617,9 @@ xfs_qm_write_sb_changes( > int > xfs_qm_vop_dqalloc( > struct xfs_inode *ip, > - uid_t uid, > - gid_t gid, > - prid_t prid, > + kuid_t uid, > + kgid_t gid, > + kprojid_t prid, > uint flags, > struct xfs_dquot **O_udqpp, > struct xfs_dquot **O_gdqpp) Probably they should use xfs_dqid_t as they are supposed to be internal XFS quota ID types.... Cheers, Dave. -- Dave Chinner david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org