From: Andrew Morton <akpm@linux-foundation.org>
To: Vyacheslav Dubeyko <slava@dubeyko.com>,
linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Hin-Tak Leung <htl10@users.sourceforge.net>
Subject: Re: [PATCH v2 2/3] hfsplus: add implementation of the ACLs support
Date: Fri, 1 Mar 2013 15:52:19 -0800 [thread overview]
Message-ID: <20130301155219.2d147e8c.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130301154710.5bf0f68f.akpm@linux-foundation.org>
On Fri, 1 Mar 2013 15:47:10 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 19 Feb 2013 17:20:47 +0400
> Vyacheslav Dubeyko <slava@dubeyko.com> wrote:
>
> > This patch adds implementation of the ACLs support for hfsplus driver.
>
> It adds a few compilation warnings (use %zd for size_t) and also adds a
> bunch of compilation errors which get fixed up in the next patch. This
> causes problems for people who are doing bisection searches.
>
> I'll drop the patches. Please fix all this up?
err,
fs/hfsplus/acl.c: In function 'hfsplus_get_acl':
fs/hfsplus/acl.c:1257: error: implicit declaration of function '__hfsplus_getxattr'
fs/hfsplus/acl.c: At top level:
fs/hfsplus/acl.c:1343: error: redefinition of 'hfsplus_init_acl'
fs/hfsplus/xattr.h:42: note: previous definition of 'hfsplus_init_acl' was here
fs/hfsplus/acl.c: In function 'hfsplus_xattr_get_acl':
fs/hfsplus/acl.c:1411: warning: format '%ld' expects type 'long int', but argument 5 has type 'size_t'
fs/hfsplus/acl.c: In function 'hfsplus_xattr_set_acl':
fs/hfsplus/acl.c:1440: warning: format '%ld' expects type 'long int', but argument 5 has type 'size_t'
next prev parent reply other threads:[~2013-03-01 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 13:20 [PATCH v2 2/3] hfsplus: add implementation of the ACLs support Vyacheslav Dubeyko
2013-03-01 23:47 ` Andrew Morton
2013-03-01 23:52 ` Andrew Morton [this message]
2013-03-03 16:47 ` Vyacheslav Dubeyko
2013-03-02 13:28 ` Vyacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301155219.2d147e8c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=htl10@users.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).