From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v2 2/3] hfsplus: add implementation of the ACLs support Date: Fri, 1 Mar 2013 15:52:19 -0800 Message-ID: <20130301155219.2d147e8c.akpm@linux-foundation.org> References: <1361280047.2037.19.camel@slavad-ubuntu> <20130301154710.5bf0f68f.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: Vyacheslav Dubeyko , linux-fsdevel@vger.kernel.org, Christoph Hellwig , Al Viro , Hin-Tak Leung Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53305 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752496Ab3CAXwU (ORCPT ); Fri, 1 Mar 2013 18:52:20 -0500 In-Reply-To: <20130301154710.5bf0f68f.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 1 Mar 2013 15:47:10 -0800 Andrew Morton wrote: > On Tue, 19 Feb 2013 17:20:47 +0400 > Vyacheslav Dubeyko wrote: > > > This patch adds implementation of the ACLs support for hfsplus driver. > > It adds a few compilation warnings (use %zd for size_t) and also adds a > bunch of compilation errors which get fixed up in the next patch. This > causes problems for people who are doing bisection searches. > > I'll drop the patches. Please fix all this up? err, fs/hfsplus/acl.c: In function 'hfsplus_get_acl': fs/hfsplus/acl.c:1257: error: implicit declaration of function '__hfsplus_getxattr' fs/hfsplus/acl.c: At top level: fs/hfsplus/acl.c:1343: error: redefinition of 'hfsplus_init_acl' fs/hfsplus/xattr.h:42: note: previous definition of 'hfsplus_init_acl' was here fs/hfsplus/acl.c: In function 'hfsplus_xattr_get_acl': fs/hfsplus/acl.c:1411: warning: format '%ld' expects type 'long int', but argument 5 has type 'size_t' fs/hfsplus/acl.c: In function 'hfsplus_xattr_set_acl': fs/hfsplus/acl.c:1440: warning: format '%ld' expects type 'long int', but argument 5 has type 'size_t'