From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH] Do not check ocfs2 Date: Sun, 3 Mar 2013 12:19:17 +1100 Message-ID: <20130303011917.GI23616@dastard> References: <1362269150-21478-1-git-send-email-richard@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org To: Richard Weinberger Return-path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:54262 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332Ab3CCBTV (ORCPT ); Sat, 2 Mar 2013 20:19:21 -0500 Content-Disposition: inline In-Reply-To: <1362269150-21478-1-git-send-email-richard@nod.at> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Mar 03, 2013 at 01:05:50AM +0100, Richard Weinberger wrote: > We cannot run fsck.ocfs2 because the file system > is most likely mounted on another node. This patch means that ocfs2 filesystems are *never* checked for consistency, even when you are testing them with exclusive local access. That defeats a primary function of xfstests - ensuring that the tests run do no corrupt the filesystem. Besides, why would you be running xfstests on a filesystem that is mounted on multiple nodes? Yes, ocfs2 is a cluster filesystem, but xfstests is designed to test local filesystem behaviour and is completely cluster naive. Hence having multiple nodes mount the filesystem that is being tested by xfstests does not serve any purpose at all. Further, turning off consistency checking for those that are running ocfs2 testing on single nodes means that testing is now mostly wasted as the majority of problems that can occur are no longer detectable.... Cheers, Dave. -- Dave Chinner david@fromorbit.com