Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

[Robin Holt <holt@sgi.com>]

On Wed, Mar 13, 2013 at 05:51:33PM +0100, Sedat Dilek wrote:
> On Wed, Mar 13, 2013 at 5:21 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> > On Wed, Mar 13, 2013 at 5:10 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> >
> >> Anyway, with CONFIG_OVERLAYFS_FS=m I do not see any related messages
> >> when the kernel-module is loaded.
> >> So, is this intended?
> >> SquashFS prints into the logs, so what is it doing differently?
> >
> > Some modules do, some don't.  It's not compulsory and not very useful.
> >
> 
> What about...
> 
> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> index 482c26f..92b9ad5 100644
> --- a/fs/overlayfs/super.c
> +++ b/fs/overlayfs/super.c
> @@ -675,11 +675,13 @@ MODULE_ALIAS_FS("overlayfs");
>  static int __init ovl_init(void)
>  {
>         return register_filesystem(&ovl_fs_type);
> +       printk(KERN_INFO "overlayfs: loaded\n");

How about pr_debug().  That makes things quite for most of us but gives
you info when looking for things like boot problems.

>  }
> 
>  static void __exit ovl_exit(void)
>  {
>         unregister_filesystem(&ovl_fs_type);
> +       printk(KERN_INFO "overlayfs: unloaded\n");
>  }
> 
>  module_init(ovl_init);
> 
> Maybe "loaded" is enough.
> 
> - Sedat -
> 
> > Thanks,
> > Miklos
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/