From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCHv2, RFC 03/30] mm: drop actor argument of
 do_generic_file_read()
Date: Fri, 15 Mar 2013 15:22:46 +0200 (EET)
Message-ID: <20130315132246.F0542E0085@blue.fi.intel.com>
References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com>
 <1363283435-7666-4-git-send-email-kirill.shutemov@linux.intel.com>
 <CAJd=RBAKGiCb_+yoFog6xao5bF8vqFwE9MGZ9EVbf1fe-dXnDQ@mail.gmail.com>
Content-Transfer-Encoding: 7bit
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
 Andrea Arcangeli <aarcange@redhat.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 Al Viro <viro@zeniv.linux.org.uk>,
 Hugh Dickins <hughd@google.com>,
 Wu Fengguang <fengguang.wu@intel.com>,
 Jan Kara <jack@suse.cz>,
 Mel Gorman <mgorman@suse.de>,
 linux-mm@kvack.org,
 Andi Kleen <ak@linux.intel.com>,
 Matthew Wilcox <matthew.r.wilcox@intel.com>,
 "Kirill A. Shutemov" <kirill@shutemov.name>,
 linux-fsdevel@vger.kernel.org,
 linux-kernel@vger.kernel.org
To: Hillf Danton <dhillf@gmail.com>
Return-path: <owner-linux-mm@kvack.org>
In-Reply-To: <CAJd=RBAKGiCb_+yoFog6xao5bF8vqFwE9MGZ9EVbf1fe-dXnDQ@mail.gmail.com>
Sender: owner-linux-mm@kvack.org
List-Id: linux-fsdevel.vger.kernel.org

Hillf Danton wrote:
> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov
> <kirill.shutemov@linux.intel.com> wrote:
> >
> > There's only one caller of do_generic_file_read() and the only actor is
> > file_read_actor(). No reason to have a callback parameter.
> >
> This cleanup is not urgent if it nukes no barrier for THP cache.

Yes, it's not urgent. On other hand it can be applied upstream right now ;)

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>