linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Maiolino <cmaiolino@redhat.com>
To: linux-fsdevel@vger.kernel.org
Cc: Josef Bacik <jbacik@fusionio.com>,
	Eric Sandeen <sandeen@redhat.com>,
	Dave Chinner <dchinner@redhat.com>,
	Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	viro@zeniv.linux.org.uk
Subject: Current behaviour of umount on a frozen FS
Date: Fri, 15 Mar 2013 16:26:39 -0300	[thread overview]
Message-ID: <20130315192638.GA1592@andromeda.usersys.redhat.com> (raw)

Hi guys, first, people Cc'ed on the email were also Cc'ed on a thread related to
a similar problem.

I'm working on a possible bug related with fsfreeze, where after frozen
filesystem is umounted the respective block device can't be mounted again,
returning to userspace, a -EBUSY error.

Discussing with Eric Sandeen about it, we identified that the current behaviour
is to make filesystem able to be umounted and mounted again; although it's kept
frozen (probably a reference to its superblock is pinned in memory once it's
mounted ?!), we are able to mount it again and thaw it.

But it raised some questions about what's the expected behaviour of this
situation, should we allow a frozen filesystem to be umounted? If yes, how about
the possibility of a snapshot corruption in case a snapshot is running when
umount is triggered?

Since we are able to mount it again, and the current state is the same before
umount, looks like we keep superblock pinned in memory and data that should have
generated I/O at umount/mount is kept in memory until the filesystem is thawed.

I saw some patches from Fernando in the list but looks like the discussion
didn't continue.

What's the current status of this behaviour on fsfreeze? should we allow a
filesystem to be umounted or not? currently, this is allowed, but, is there
something protecting snapshots to be corrupted or is this being handled as an
unlikely situation?

Cheers,
-- 
Carlos

             reply	other threads:[~2013-03-15 19:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 19:26 Carlos Maiolino [this message]
2013-03-18 17:53 ` Current behaviour of umount on a frozen FS Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130315192638.GA1592@andromeda.usersys.redhat.com \
    --to=cmaiolino@redhat.com \
    --cc=dchinner@redhat.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jbacik@fusionio.com \
    --cc=lcapitulino@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).