From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] fs: block pipe_write() on a frozen filesystem PING..
Date: Tue, 2 Apr 2013 20:57:27 +0100
Message-ID: <20130402195727.GJ21522@ZenIV.linux.org.uk>
References: <5064752F.5000207@redhat.com>
 <87zjxhqf9d.fsf@openvz.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Eric Sandeen <sandeen@redhat.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Jan Kara <jack@suse.cz>,
	Fernando Luis Vazquez Cao <fernando_b1@lab.ntt.co.jp>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:42151 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932700Ab3DBT5h (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 2 Apr 2013 15:57:37 -0400
Content-Disposition: inline
In-Reply-To: <87zjxhqf9d.fsf@openvz.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Apr 02, 2013 at 04:38:22PM +0400, Dmitry Monakhov wrote:
> On Thu, 27 Sep 2012 10:47:59 -0500, Eric Sandeen <sandeen@redhat.com> wrote:
> > I noticed that this can sneak past a frozen filesystem:
> Ping.. any body want to take care about that patch?

NAK.  Note that writing to FIFO that sits on filesystem that is outright
read-only is allowed just fine; blocking it for frozen ones is bogus.

IOW, it should be treated the same way we treat touch_atime().  Moreover,
it should only be done around file_update_time().  With trylock.