From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 25/28] proc: Supply an accessor to get the process ID associated with some proc files [RFC] Date: Thu, 18 Apr 2013 11:39:50 -0700 Message-ID: <20130418183950.GJ9897@mtj.dyndns.org> References: <20130416182550.27773.89310.stgit@warthog.procyon.org.uk> <20130416182730.27773.88726.stgit@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Howells Return-path: Content-Disposition: inline In-Reply-To: <20130416182730.27773.88726.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org Hello, David. On Tue, Apr 16, 2013 at 07:27:30PM +0100, David Howells wrote: > +struct pid *get_proc_pid(const struct inode *inode) > +{ > + return PROC_I(inode)->pid; > +} Maybe we can add /** comment explaining what this is about? Other than that, it looks fine to me. It probably would be best to route this through -mm given it touches /proc too, so cc Andrew on the next posting? Thanks. -- tejun