From: Jan Kara <jack@suse.cz>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v3 18/18] ext4: Allow punch hole with bigalloc enabled
Date: Sat, 20 Apr 2013 15:43:16 +0200 [thread overview]
Message-ID: <20130420134316.GB2461@quack.suse.cz> (raw)
In-Reply-To: <1365498867-27782-19-git-send-email-lczerner@redhat.com>
On Tue 09-04-13 11:14:27, Lukas Czerner wrote:
> In commits 5f95d21fb6f2aaa52830e5b7fb405f6c71d3ab85 and
> 30bc2ec9598a1b156ad75217f2e7d4560efdeeab we've reworked punch_hole
> implementation and there is noting holding us back from using punch hole
> on file system with bigalloc feature enabled.
>
> This has been tested with fsx and xfstests.
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> fs/ext4/inode.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 0d452c1..87d6171 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3536,11 +3536,6 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length)
> if (!S_ISREG(inode->i_mode))
> return -EOPNOTSUPP;
>
> - if (EXT4_SB(sb)->s_cluster_ratio > 1) {
> - /* TODO: Add support for bigalloc file systems */
> - return -EOPNOTSUPP;
> - }
> -
> trace_ext4_punch_hole(inode, offset, length);
>
> /*
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2013-04-20 13:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 9:14 [PATCH v3 00/18] change invalidatepage prototype to accept length Lukas Czerner
2013-04-09 9:14 ` [PATCH v3 01/18] mm: " Lukas Czerner
2013-04-09 9:14 ` [PATCH v3 02/18] jbd2: change jbd2_journal_invalidatepage " Lukas Czerner
2013-04-09 13:22 ` Jan Kara
2013-04-09 9:14 ` [PATCH v3 03/18] ext4: use ->invalidatepage() length argument Lukas Czerner
2013-04-09 13:24 ` Jan Kara
2013-04-09 9:14 ` [PATCH v3 04/18] jbd: change journal_invalidatepage() to accept length Lukas Czerner
2013-04-09 13:20 ` Jan Kara
2013-04-09 9:14 ` [PATCH v3 05/18] xfs: use ->invalidatepage() length argument Lukas Czerner
2013-04-23 14:14 ` Theodore Ts'o
2013-04-23 21:06 ` Ben Myers
2013-04-09 9:14 ` [PATCH v3 06/18] ocfs2: " Lukas Czerner
2013-04-09 13:26 ` Jan Kara
2013-04-23 14:16 ` Theodore Ts'o
2013-05-02 22:00 ` Joel Becker
2013-04-09 9:14 ` [PATCH v3 07/18] ceph: " Lukas Czerner
2013-04-23 14:14 ` Theodore Ts'o
2013-04-23 16:04 ` Sage Weil
2013-04-09 9:14 ` [PATCH v3 08/18] gfs2: " Lukas Czerner
2013-04-09 9:29 ` [Cluster-devel] " Steven Whitehouse
2013-04-09 13:09 ` Bob Peterson
2013-04-09 13:27 ` Lukáš Czerner
2013-04-23 14:16 ` Theodore Ts'o
2013-04-23 14:17 ` Theodore Ts'o
2013-04-09 9:14 ` [PATCH v3 09/18] reiserfs: " Lukas Czerner
2013-04-09 13:27 ` Jan Kara
2013-04-10 9:51 ` Lukáš Czerner
2013-04-09 9:14 ` [PATCH v3 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges Lukas Czerner
2013-04-11 21:18 ` Jan Kara
2013-04-11 22:40 ` Hugh Dickins
2013-04-09 9:14 ` [PATCH v3 11/18] Revert "ext4: remove no longer used functions in inode.c" Lukas Czerner
2013-04-18 22:08 ` Jan Kara
2013-04-09 9:14 ` [PATCH v3 12/18] Revert "ext4: fix fsx truncate failure" Lukas Czerner
2013-04-18 22:21 ` Jan Kara
2013-04-09 9:14 ` [PATCH v3 13/18] ext4: use ext4_zero_partial_blocks in punch_hole Lukas Czerner
2013-04-19 5:03 ` Jan Kara
2013-04-09 9:14 ` [PATCH v3 14/18] ext4: remove unused discard_partial_page_buffers Lukas Czerner
2013-04-19 5:04 ` Jan Kara
2013-04-09 9:14 ` [PATCH v3 15/18] ext4: remove unused code from ext4_remove_blocks() Lukas Czerner
2013-04-19 5:15 ` Jan Kara
2013-04-09 9:14 ` [PATCH v3 16/18] ext4: update ext4_ext_remove_space trace point Lukas Czerner
2013-04-19 5:16 ` Jan Kara
2013-04-09 9:14 ` [PATCH v3 17/18] ext4: make punch hole code path work with bigalloc Lukas Czerner
2013-04-20 13:42 ` Jan Kara
2013-04-23 9:19 ` Zheng Liu
2013-04-24 11:08 ` Lukáš Czerner
2013-04-24 11:29 ` Zheng Liu
2013-04-24 10:57 ` Lukáš Czerner
2013-04-09 9:14 ` [PATCH v3 18/18] ext4: Allow punch hole with bigalloc enabled Lukas Czerner
2013-04-20 13:43 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130420134316.GB2461@quack.suse.cz \
--to=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).