From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: question about buffer_busy check Date: Tue, 23 Apr 2013 21:18:36 +0100 Message-ID: <20130423201836.GM4068@ZenIV.linux.org.uk> References: <8738uh5va9.fsf@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: LKML , linux-fsdevel@vger.kernel.org, Andrew Morton To: Dmitry Monakhov Return-path: Content-Disposition: inline In-Reply-To: <8738uh5va9.fsf@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Apr 23, 2013 at 03:41:18PM +0400, Dmitry Monakhov wrote: > The only guess I have is that this is a miss typo because buffer > is busy if some one hold an reference (bh->b_count !=0 ) || > it is (dirty | locked). So following patch ... is pointless. All callers only care about the return value being zero or non-zero and not about specific values. Granted, doing it that way is a micro-optimization, but it's still a valid one.