From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
"J. Bruce Fields" <bfields@redhat.com>,
"David P. Quigley" <dpquigl@tycho.nsa.gov>,
Linux NFS list <linux-nfs@vger.kernel.org>,
Linux FS devel list <linux-fsdevel@vger.kernel.org>,
Linux Security List <linux-security-module@vger.kernel.org>,
SELinux List <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 01/17] NFSv4.2: Added v4.2 error codes
Date: Wed, 24 Apr 2013 17:54:11 -0400 [thread overview]
Message-ID: <20130424215411.GL20275@fieldses.org> (raw)
In-Reply-To: <1366834683-29075-2-git-send-email-SteveD@redhat.com>
On Wed, Apr 24, 2013 at 04:17:47PM -0400, Steve Dickson wrote:
> From: Steve Dickson <steved@redhat.com>
This seems uncontroversial; applying to 3.10 absent any objections,
except:
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> fs/nfsd/nfsd.h | 6 ++++++
> fs/nfsd/nfsproc.c | 1 +
> include/linux/nfs4.h | 8 ++++++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
> index 07a473f..553b230 100644
> --- a/fs/nfsd/nfsd.h
> +++ b/fs/nfsd/nfsd.h
> @@ -243,6 +243,12 @@ void nfsd_lockd_shutdown(void);
> #define nfserr_reject_deleg cpu_to_be32(NFS4ERR_REJECT_DELEG)
> #define nfserr_returnconflict cpu_to_be32(NFS4ERR_RETURNCONFLICT)
> #define nfserr_deleg_revoked cpu_to_be32(NFS4ERR_DELEG_REVOKED)
> +#define nfserr_partner_notsupp cpu_to_be32(NFS4ERR_PARTNER_NOTSUPP)
> +#define nfserr_partner_no_auth cpu_to_be32(NFS4ERR_PARTNER_NO_AUTH)
> +#define nfserr_metadata_notsupp cpu_to_be32(NFS4ERR_METADATA_NOTSUPP)
> +#define nfserr_offload_denied cpu_to_be32(NFS4ERR_OFFLOAD_DENIED)
> +#define nfserr_wrong_lfs cpu_to_be32(NFS4ERR_WRONG_LFS)
> +#define nfs4err_badlabel cpu_to_be32(NFS4ERR_BADLABEL)
>
> /* error codes for internal use */
> /* if a request fails due to kmalloc failure, it gets dropped.
> diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c
> index 54c6b3d..85289a5 100644
> --- a/fs/nfsd/nfsproc.c
> +++ b/fs/nfsd/nfsproc.c
> @@ -743,6 +743,7 @@ nfserrno (int errno)
> { nfserr_notsupp, -EOPNOTSUPP },
> { nfserr_toosmall, -ETOOSMALL },
> { nfserr_serverfault, -ESERVERFAULT },
> + { nfs4err_badlabel, -EMSGSIZE },
dropping this one chunk, it should probably go in patch 16/17 with the
other nfsd code.
--b.
> };
> int i;
>
> diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h
> index 7b8fc73..377fb3f 100644
> --- a/include/linux/nfs4.h
> +++ b/include/linux/nfs4.h
> @@ -219,6 +219,14 @@ enum nfsstat4 {
> NFS4ERR_REJECT_DELEG = 10085, /* on callback */
> NFS4ERR_RETURNCONFLICT = 10086, /* outstanding layoutreturn */
> NFS4ERR_DELEG_REVOKED = 10087, /* deleg./layout revoked */
> +
> + /* nfs42 */
> + NFS4ERR_PARTNER_NOTSUPP = 10088,
> + NFS4ERR_PARTNER_NO_AUTH = 10089,
> + NFS4ERR_METADATA_NOTSUPP = 10090,
> + NFS4ERR_OFFLOAD_DENIED = 10091,
> + NFS4ERR_WRONG_LFS = 10092,
> + NFS4ERR_BADLABEL = 10093,
> };
>
> static inline bool seqid_mutating_err(u32 err)
> --
> 1.8.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-04-24 21:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 20:17 [PATCH 00/17] lnfs: 3.9-rc8 release Steve Dickson
2013-04-24 20:17 ` [PATCH 01/17] NFSv4.2: Added v4.2 error codes Steve Dickson
2013-04-24 21:54 ` J. Bruce Fields [this message]
2013-04-24 20:17 ` [PATCH 02/17] NFSv4.2: Added NFS v4.2 support to the NFS client Steve Dickson
2013-04-24 21:56 ` J. Bruce Fields
2013-04-24 20:17 ` [PATCH 03/17] NFSDv4.2: Added NFS v4.2 support to the NFS server Steve Dickson
2013-04-24 22:02 ` J. Bruce Fields
[not found] ` <20130424220226.GN20275-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-04-25 14:10 ` Steve Dickson
2013-04-25 18:26 ` J. Bruce Fields
2013-04-24 20:17 ` [PATCH 04/17] Security: Add hook to calculate context based on a negative dentry Steve Dickson
2013-04-24 22:02 ` J. Bruce Fields
[not found] ` <20130424220258.GO20275-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-04-24 22:09 ` David Quigley
2013-04-24 22:12 ` Steve Dickson
[not found] ` <517858D1.5000406-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2013-04-24 22:14 ` David Quigley
[not found] ` <faf7db0bcd9b208c201a652c718c720c-fuEpAR7jH0UNb0vsIHg089HuzzzSOjJt@public.gmane.org>
2013-04-24 23:03 ` J. Bruce Fields
2013-04-24 23:05 ` David Quigley
2013-04-25 1:27 ` Casey Schaufler
[not found] ` <5178867E.30704-iSGtlc1asvQWG2LlvL+J4A@public.gmane.org>
2013-04-25 1:43 ` J. Bruce Fields
2013-04-24 20:17 ` [PATCH 06/17] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
2013-04-24 22:03 ` J. Bruce Fields
2013-04-24 20:17 ` [PATCH 07/17] SELinux: Add new labeling type native labels Steve Dickson
2013-04-24 22:03 ` J. Bruce Fields
[not found] ` <20130424220359.GR20275-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2013-04-24 22:06 ` David Quigley
2013-04-24 20:17 ` [PATCH 09/17] NFSv4: Introduce new label structure Steve Dickson
2013-04-24 20:17 ` [PATCH 10/17] NFSv4: Extend fattr bitmaps to support all 3 words Steve Dickson
[not found] ` <1366834683-29075-1-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-24 20:17 ` [PATCH 05/17] Security: Add Hook to test if the particular xattr is part of a MAC model Steve Dickson
2013-04-24 22:03 ` J. Bruce Fields
2013-04-24 20:17 ` [PATCH 08/17] NFSv4: Add label recommended attribute and NFSv4 flags Steve Dickson
2013-04-24 20:17 ` [PATCH 11/17] NFS:Add labels to client function prototypes Steve Dickson
2013-04-24 20:17 ` [PATCH 13/17] NFS: Client implementation of Labeled-NFS Steve Dickson
2013-04-24 20:18 ` [PATCH 15/17] Kconfig: Add Kconfig entry for Labeled NFS V4 client Steve Dickson
2013-04-24 20:17 ` [PATCH 12/17] NFS: Add label lifecycle management Steve Dickson
2013-04-24 20:18 ` [PATCH 14/17] NFS: Extend NFS xattr handlers to accept the security namespace Steve Dickson
2013-04-24 20:18 ` [PATCH 16/17] NFSD: Server implementation of MAC Labeling Steve Dickson
2013-04-24 21:28 ` J. Bruce Fields
2013-04-24 22:14 ` Steve Dickson
[not found] ` <51785962.7080008-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2013-04-24 23:04 ` J. Bruce Fields
2013-04-24 20:18 ` [PATCH 17/17] Kconfig: Add Kconfig entry for Labeled NFS V4 server Steve Dickson
-- strict thread matches above, loose matches on Subject: below --
2013-04-29 12:57 [PATCH 00/17] lnfs: 3.9-rc8 release (take 2) Steve Dickson
2013-04-29 12:57 ` [PATCH 01/17] NFSv4.2: Added v4.2 error codes Steve Dickson
2013-05-02 17:18 [PATCH 00/17] lnfs: linux-3.9 release Steve Dickson
2013-05-02 17:18 ` [PATCH 01/17] NFSv4.2: Added v4.2 error codes Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424215411.GL20275@fieldses.org \
--to=bfields@fieldses.org \
--cc=SteveD@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@redhat.com \
--cc=dpquigl@tycho.nsa.gov \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).