linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: remaper <yp.fangdong@gmail.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: generic_make_request not locked
Date: Tue, 30 Apr 2013 08:08:29 +0200	[thread overview]
Message-ID: <20130430060829.GF9563@kernel.dk> (raw)
In-Reply-To: <tencent_0BD3EAC403C9DFE43143959B@qq.com>

On Tue, Apr 30 2013, remaper wrote:
> /*
>  * We only want one ->make_request_fn to be active at a time,
>  * else stack usage with stacked devices could be a problem.
>  * So use current->bio_list to keep a list of requests
>  * submited by a make_request_fn function.
>  * current->bio_list is also used as a flag to say if
>  * generic_make_request is currently active in this task or not.
>  * If it is NULL, then no make_request is active.  If it is non-NULL,
>  * then a make_request is active, and new requests should be added
>  * at the tail
>  */
> void generic_make_request(struct bio *bio)
> {
> ...
>     if (current->bio_list) {
>         /* make_request is active */
>         bio_list_add(current->bio_list, bio);
>         return;
>     }
> ...
> }
> 
> current->bio_list is a global variable, and generic_make_request would
> run on multithread environment, so, i don't understand why here(
> bio_list_add ) not lock?  thx everybody.

'current' refers to the task currently executing task. So
current->bio_list isn't shared, hence there's no need for any locking.

-- 
Jens Axboe

           reply	other threads:[~2013-04-30  6:08 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <tencent_0BD3EAC403C9DFE43143959B@qq.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130430060829.GF9563@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yp.fangdong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).