From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [REGRESSION] bisected: 3.8 -> 3.9 cannot umount after using fuse Date: Sat, 4 May 2013 16:52:14 +0100 Message-ID: <20130504155214.GD25399@ZenIV.linux.org.uk> References: <20130504124519.032ac684@xenia.leun.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, gregkh@linuxfoundation.org To: Michael Leun Return-path: Content-Disposition: inline In-Reply-To: <20130504124519.032ac684@xenia.leun.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, May 04, 2013 at 12:45:19PM +0200, Michael Leun wrote: > After reverting 57eccb830f1cc93d4b506ba306d8dfa685e0c88f from 3.9 that > umount above works (not busy). Sigh... Check if the following fix works for your testcase: diff --git a/fs/namespace.c b/fs/namespace.c index b4f96a5..b68eef2d 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2284,12 +2284,11 @@ long do_mount(const char *dev_name, const char *dir_name, retval = security_sb_mount(dev_name, &path, type_page, flags, data_page); + if (!retval && !may_mount()) + retval = -EPERM; if (retval) goto dput_out; - if (!may_mount()) - return -EPERM; - /* Default to relatime unless overriden */ if (!(flags & MS_NOATIME)) mnt_flags |= MNT_RELATIME;