linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
	Nikola Ciprich <nikola.ciprich@linuxbox.cz>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] fs: Fix hang with BSD accounting on frozen filesystem
Date: Sat, 4 May 2013 19:58:57 +0100	[thread overview]
Message-ID: <20130504185857.GG25399@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1367619083-8093-1-git-send-email-jack@suse.cz>

On Sat, May 04, 2013 at 12:11:23AM +0200, Jan Kara wrote:
> When BSD process accounting is enabled and logs information to a
> filesystem which gets frozen, system easily becomes unusable because
> each attempt to account process information blocks. Thus e.g. every task
> gets blocked in exit.
> 
> It seems better to drop accounting information (which can already happen
> when filesystem is running out of space) instead of locking system up.
> So we just skip the write if the filesystem is frozen.

Applied, with one modification - file_start_write_trylock() added and
used instead of sb_start_write_trylock()

      reply	other threads:[~2013-05-04 18:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03 22:11 [PATCH v2] fs: Fix hang with BSD accounting on frozen filesystem Jan Kara
2013-05-04 18:58 ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130504185857.GG25399@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikola.ciprich@linuxbox.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).