From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Mason Subject: Re: [BULK] Re: [PATCH RFC 0/2] skiplists for range indexes Date: Mon, 6 May 2013 07:28:19 -0400 Message-ID: <20130506112819.5844.57295@localhost.localdomain> References: <20130503020211.3599.72404@localhost.localdomain> <20130503091924.GD10633@quack.suse.cz> <20130503104525.5844.57452@localhost.localdomain> <20130504032536.GD19978@dastard> <20130504111151.5844.74450@localhost.localdomain> <20130505073357.GC2010@devil.localdomain> <20130505143812.5844.41278@localhost.localdomain> <20130505224416.GH19978@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Cc: Dave Chinner , Jan Kara , Linux FS Devel , David Woodhouse , "bo.li.liu@oracle.com" To: Dave Chinner Return-path: Received: from dkim2.fusionio.com ([66.114.96.54]:50245 "EHLO dkim2.fusionio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346Ab3EFL2W convert rfc822-to-8bit (ORCPT ); Mon, 6 May 2013 07:28:22 -0400 Received: from mx2.fusionio.com (unknown [10.101.1.160]) by dkim2.fusionio.com (Postfix) with ESMTP id 34F389A067D for ; Mon, 6 May 2013 05:28:22 -0600 (MDT) In-Reply-To: <20130505224416.GH19978@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Quoting Dave Chinner (2013-05-05 18:44:16) > On Sun, May 05, 2013 at 10:38:12AM -0400, Chris Mason wrote: > > It's an rbtree per allocation group. The code is doing an exact > extent match and there is potential for multiple buffers at the same > offset (key) into the tree so we can't use a radix tree at all. See > _xfs_buf_find() for the rbtree search code... The exact match part won't work with my current code. But a small change will let you pick your own insertion point and allow the duplicates. I'll have to break up deletion a little as well, but it is already setup for this. After the merge window, I've got linuxcon japan. Once both are done I'll pick this up again and see what I can do. -chris