From: Dave Chinner <david@fromorbit.com>
To: Chris Mason <clmason@fusionio.com>
Cc: Dave Chinner <dchinner@redhat.com>, Jan Kara <jack@suse.cz>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
David Woodhouse <David.Woodhouse@intel.com>,
"bo.li.liu@oracle.com" <bo.li.liu@oracle.com>
Subject: Re: [BULK] Re: [PATCH RFC 0/2] skiplists for range indexes
Date: Tue, 7 May 2013 12:12:08 +1000 [thread overview]
Message-ID: <20130507021207.GR19978@dastard> (raw)
In-Reply-To: <20130506112819.5844.57295@localhost.localdomain>
On Mon, May 06, 2013 at 07:28:19AM -0400, Chris Mason wrote:
> Quoting Dave Chinner (2013-05-05 18:44:16)
> > On Sun, May 05, 2013 at 10:38:12AM -0400, Chris Mason wrote:
> >
> > It's an rbtree per allocation group. The code is doing an exact
> > extent match and there is potential for multiple buffers at the same
> > offset (key) into the tree so we can't use a radix tree at all. See
> > _xfs_buf_find() for the rbtree search code...
>
> The exact match part won't work with my current code. But a small
> change will let you pick your own insertion point and allow the
> duplicates. I'll have to break up deletion a little as well, but it is
> already setup for this.
>
> After the merge window, I've got linuxcon japan. Once both are done
> I'll pick this up again and see what I can do.
No worries - I'm not in any hurry to replace this code right now.
Reducing the number of unnecessary/repeated buffer lookups is
probably a bigger win for XFS right now...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2013-05-07 2:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 2:02 [PATCH RFC 0/2] skiplists for range indexes Chris Mason
2013-05-03 2:06 ` [PATCH RFC 1/2] core skiplist code Chris Mason
2013-05-03 2:10 ` [PATCH RFC 2/2] skiplists for the IOMMU Chris Mason
2013-05-03 9:19 ` [PATCH RFC 0/2] skiplists for range indexes Jan Kara
2013-05-03 10:45 ` Chris Mason
2013-05-04 3:25 ` Dave Chinner
2013-05-04 11:11 ` Chris Mason
2013-05-05 7:33 ` Dave Chinner
2013-05-05 14:38 ` Chris Mason
2013-05-05 22:44 ` Dave Chinner
2013-05-06 11:28 ` [BULK] " Chris Mason
2013-05-07 2:12 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507021207.GR19978@dastard \
--to=david@fromorbit.com \
--cc=David.Woodhouse@intel.com \
--cc=bo.li.liu@oracle.com \
--cc=clmason@fusionio.com \
--cc=dchinner@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).