[PATCH 02/21] fs: remove inline marking of EXPORT_SYMBOL functions

[PATCH 02/21] fs: remove inline marking of EXPORT_SYMBOL functions

[Denis Efremov]

EXPORT_SYMBOL and inline directives are contradictory to each other.
The patch fixes this inconsistency.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
---
 fs/bio.c       | 2 +-
 fs/block_dev.c | 2 +-
 fs/buffer.c    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/bio.c b/fs/bio.c
index b96fc6c..4e1235f 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -402,7 +402,7 @@ void bio_put(struct bio *bio)
 }
 EXPORT_SYMBOL(bio_put);
 
-inline int bio_phys_segments(struct request_queue *q, struct bio *bio)
+int bio_phys_segments(struct request_queue *q, struct bio *bio)
 {
 	if (unlikely(!bio_flagged(bio, BIO_SEG_VALID)))
 		blk_recount_segments(q, bio);
diff --git a/fs/block_dev.c b/fs/block_dev.c
index ce08de7..799d879 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -42,7 +42,7 @@ static inline struct bdev_inode *BDEV_I(struct inode *inode)
 	return container_of(inode, struct bdev_inode, vfs_inode);
 }
 
-inline struct block_device *I_BDEV(struct inode *inode)
+struct block_device *I_BDEV(struct inode *inode)
 {
 	return &BDEV_I(inode)->bdev;
 }
diff --git a/fs/buffer.c b/fs/buffer.c
index bc1fe14..c3cfe44 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -54,7 +54,7 @@ void init_buffer(struct buffer_head *bh, bh_end_io_t *handler, void *private)
 }
 EXPORT_SYMBOL(init_buffer);
 
-inline void touch_buffer(struct buffer_head *bh)
+void touch_buffer(struct buffer_head *bh)
 {
 	trace_block_touch_buffer(bh);
 	mark_page_accessed(bh->b_page);
-- 
1.8.1.4

Re: [PATCH 02/21] fs: remove inline marking of EXPORT_SYMBOL functions

[Al Viro]

On Thu, May 09, 2013 at 11:58:24AM +0400, Denis Efremov wrote:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.

What makes them contradictory, in your opinion?  With references to
relevant parts of C99, please.

Re: [PATCH 02/21] fs: remove inline marking of EXPORT_SYMBOL functions

[Denis]

On 09.05.2013 12:07, Al Viro wrote:
> On Thu, May 09, 2013 at 11:58:24AM +0400, Denis Efremov wrote:
>> EXPORT_SYMBOL and inline directives are contradictory to each other.
>> The patch fixes this inconsistency.
> What makes them contradictory, in your opinion?  With references to
> relevant parts of C99, please.
Looks like the introductory message was rejected by mailing list.
Will try to do something with this. You can find it here:
http://linuxtesting.org/pipermail/ldv-project/2013-May/000101.html

Patchset is based on previous fixes.