From: "Jörn Engel" <joern@logfs.org>
To: Vyacheslav Dubeyko <slava@dubeyko.com>
Cc: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Clemens Eisserer <linuxhippy@gmail.com>
Subject: Re: [PATCH v5 2/2] nilfs2: use atomic_long_t type for inodes_count and blocks_count fields in nilfs_root struct
Date: Fri, 24 May 2013 15:01:46 -0400 [thread overview]
Message-ID: <20130524190146.GF30270@logfs.org> (raw)
In-Reply-To: <C2E05418-7137-46A8-AEC9-0E6A10F42669@dubeyko.com>
On Fri, 24 May 2013 23:30:10 +0400, Vyacheslav Dubeyko wrote:
> On May 24, 2013, at 9:54 PM, Jörn Engel wrote:
> > On Fri, 24 May 2013 17:32:52 +0400, Vyacheslav Dubeyko wrote:
> >>
> >> Subject: [PATCH v5 2/2] nilfs2: use atomic_long_t type for inodes_count
> > ...
> >> The cp_inodes_count and cp_blocks_count are represented as
> >> __le64 type in on-disk structure (struct nilfs_checkpoint).
> >
> > Isn't atomic_long_t defined to be 32bit on 32bit architectures?
>
> As I understand, yes.
And it doesn't concern you to use a 32bit memory structure to
represent a 64bit on-disk structure? ;)
Jörn
--
Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-05-24 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 13:32 [PATCH v5 2/2] nilfs2: use atomic_long_t type for inodes_count and blocks_count fields in nilfs_root struct Vyacheslav Dubeyko
2013-05-24 17:43 ` Ryusuke Konishi
2013-05-24 17:54 ` Jörn Engel
[not found] ` <20130524175406.GD30270-PCqxUs/MD9bYtjvyW6yDsg@public.gmane.org>
2013-05-24 19:30 ` Vyacheslav Dubeyko
2013-05-24 19:01 ` Jörn Engel [this message]
[not found] ` <20130524190146.GF30270-PCqxUs/MD9bYtjvyW6yDsg@public.gmane.org>
2013-05-24 22:01 ` Vyacheslav Dubeyko
2013-05-24 21:37 ` Jörn Engel
2013-05-25 3:33 ` Ryusuke Konishi
[not found] ` <20130525.123303.412805468.konishi.ryusuke-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org>
2013-05-26 12:18 ` Vyacheslav Dubeyko
[not found] ` <DF00B7E3-7352-4AEC-B0D9-AB7E624E5793-yeENwD64cLxBDgjK7y7TUQ@public.gmane.org>
2013-05-26 14:43 ` Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524190146.GF30270@logfs.org \
--to=joern@logfs.org \
--cc=akpm@linux-foundation.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linuxhippy@gmail.com \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).