From: Dave Chinner <david@fromorbit.com>
To: Glauber Costa <glommer@openvz.org>
Cc: linux-fsdevel@vger.kernel.org, Mel Gorman <mgorman@suse.de>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
kamezawa.hiroyu@jp.fujitsu.com,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Tejun Heo <tj@kernel.org>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v8 16/34] xfs: convert buftarg LRU to generic code
Date: Sat, 25 May 2013 10:27:59 +1000 [thread overview]
Message-ID: <20130525002759.GK24543@dastard> (raw)
In-Reply-To: <1369391368-31562-17-git-send-email-glommer@openvz.org>
On Fri, May 24, 2013 at 03:59:10PM +0530, Glauber Costa wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Convert the buftarg LRU to use the new generic LRU list and take
> advantage of the functionality it supplies to make the buffer cache
> shrinker node aware.
>
> * v7: Add NUMA aware flag
I know what is wrong with this patch that causes the unmount hang -
it's the handling of the _XBF_LRU_DISPOSE flag no longer being
modified atomically with the LRU lock. Hence there is a race where
we can either lose the _XBF_LRU_DISPOSE or not see it and hence we
can end up with code not detecting what list the buffer is on
correctly.
I haven't had a chance to work out a fix for it yet. If this ends up
likely to hold up the patch set, Glauber, then feel free to drop it
from the series and I'll push a fixed version through the XFS tree
in due course....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-05-25 0:27 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 10:28 [PATCH v8 00/34] kmemcg shrinkers Glauber Costa
2013-05-24 10:28 ` [PATCH v8 02/34] super: fix calculation of shrinkable objects for small numbers Glauber Costa
[not found] ` <1369391368-31562-1-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2013-05-24 10:28 ` [PATCH v8 01/34] fs: bump inode and dentry counters to long Glauber Costa
2013-05-24 10:28 ` [PATCH v8 03/34] dcache: convert dentry_stat.nr_unused to per-cpu counters Glauber Costa
2013-05-24 10:28 ` [PATCH v8 04/34] dentry: move to per-sb LRU locks Glauber Costa
2013-05-24 10:28 ` [PATCH v8 05/34] dcache: remove dentries from LRU before putting on dispose list Glauber Costa
2013-05-24 10:29 ` [PATCH v8 06/34] mm: new shrinker API Glauber Costa
2013-05-24 10:29 ` [PATCH v8 07/34] shrinker: convert superblock shrinkers to new API Glauber Costa
2013-05-24 10:29 ` [PATCH v8 08/34] list: add a new LRU list type Glauber Costa
2013-05-24 10:29 ` [PATCH v8 09/34] inode: convert inode lru list to generic lru list code Glauber Costa
2013-05-24 10:29 ` [PATCH v8 10/34] dcache: convert to use new lru list infrastructure Glauber Costa
2013-05-24 10:29 ` [PATCH v8 11/34] list_lru: per-node " Glauber Costa
2013-05-24 10:29 ` [PATCH v8 12/34] shrinker: add node awareness Glauber Costa
2013-05-24 10:29 ` [PATCH v8 13/34] vmscan: per-node deferred work Glauber Costa
2013-05-24 10:29 ` [PATCH v8 14/34] list_lru: per-node API Glauber Costa
2013-05-24 10:29 ` [PATCH v8 15/34] fs: convert inode and dentry shrinking to be node aware Glauber Costa
2013-05-24 10:29 ` [PATCH v8 16/34] xfs: convert buftarg LRU to generic code Glauber Costa
2013-05-25 0:27 ` Dave Chinner [this message]
2013-05-28 15:56 ` Glauber Costa
[not found] ` <51A4D3B5.6060802-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-05-29 10:15 ` Dave Chinner
2013-05-29 10:51 ` Glauber Costa
[not found] ` <51A5DDCE.509-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2013-05-29 12:25 ` Dave Chinner
2013-05-30 7:43 ` Dave Chinner
2013-05-24 10:29 ` [PATCH v8 17/34] xfs: convert dquot cache lru to list_lru Glauber Costa
2013-05-24 10:29 ` [PATCH v8 18/34] fs: convert fs shrinkers to new scan/count API Glauber Costa
2013-05-24 10:44 ` Steven Whitehouse
2013-05-24 10:29 ` [PATCH v8 20/34] i915: bail out earlier when shrinker cannot acquire mutex Glauber Costa
[not found] ` <1369391368-31562-21-git-send-email-glommer-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
2013-05-24 21:57 ` Daniel Vetter
2013-05-24 10:29 ` [PATCH v8 21/34] shrinker: convert remaining shrinkers to count/scan API Glauber Costa
2013-05-24 10:29 ` [PATCH v8 22/34] hugepage: convert huge zero page shrinker to new shrinker API Glauber Costa
2013-05-24 10:29 ` [PATCH v8 23/34] shrinker: Kill old ->shrink API Glauber Costa
2013-05-24 10:29 ` [PATCH v8 24/34] vmscan: also shrink slab in memcg pressure Glauber Costa
2013-05-24 10:29 ` [PATCH v8 25/34] memcg,list_lru: duplicate LRUs upon kmemcg creation Glauber Costa
2013-05-24 10:29 ` [PATCH v8 26/34] lru: add an element to a memcg list Glauber Costa
2013-05-24 10:29 ` [PATCH v8 27/34] list_lru: per-memcg walks Glauber Costa
2013-05-24 10:29 ` [PATCH v8 28/34] memcg: per-memcg kmem shrinking Glauber Costa
2013-05-24 10:29 ` [PATCH v8 29/34] memcg: scan cache objects hierarchically Glauber Costa
2013-05-24 10:29 ` [PATCH v8 31/34] super: targeted memcg reclaim Glauber Costa
2013-05-24 10:29 ` [PATCH v8 32/34] memcg: move initialization to memcg creation Glauber Costa
2013-05-24 10:29 ` [PATCH v8 33/34] vmpressure: in-kernel notifications Glauber Costa
2013-05-24 10:29 ` [PATCH v8 34/34] memcg: reap dead memcgs upon global memory pressure Glauber Costa
2013-05-24 10:29 ` [PATCH v8 19/34] drivers: convert shrinkers to new count/scan API Glauber Costa
2013-05-24 10:29 ` [PATCH v8 30/34] vmscan: take at least one pass with shrinkers Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130525002759.GK24543@dastard \
--to=david@fromorbit.com \
--cc=cgroups@vger.kernel.org \
--cc=dchinner@redhat.com \
--cc=glommer@openvz.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).