From mboxrd@z Thu Jan 1 00:00:00 1970 From: "George Spelvin" Subject: Re: [PATCH v3] jbd2: Fix block tag checksum verification brokenness Date: 2 Jun 2013 22:16:30 -0400 Message-ID: <20130603021630.13790.qmail@science.horizon.com> Cc: linux@horizon.com, linux-fsdevel@vger.kernel.org To: darrick.wong@oracle.com Return-path: Received: from science.horizon.com ([71.41.210.146]:33865 "HELO science.horizon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756892Ab3FCCXM (ORCPT ); Sun, 2 Jun 2013 22:23:12 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > Fortunately metadata checksumming is still "experimental" and not in a shipping > e2fsprogs, so there should be few users affected by this. Am I reading this patch correctly that this changes which half of the 32-bit checksum is stored on little-endian (e.g. x86) machines? Before, it stored the low 16 bits of cpu_to_be32(csum), meaning the high 16 bits of csum. Now, it's cpu_to_be16(csum32), which is the low 16 bits of csum32. It so happens that I have multiple metadata_csum file systems. (I enabled it a while ago on a machine where I wasn't sure if corruption was RAM or disk, and have been using it on SSE4.2 machines since.) Is there an upgrade path? Also, what's the corresponding e2fsprogs commit that supports this change?