From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v10 12/35] shrinker: add node awareness Date: Wed, 5 Jun 2013 16:08:10 -0700 Message-ID: <20130605160810.5b203c3368b9df7d087ee3b1@linux-foundation.org> References: <1370287804-3481-1-git-send-email-glommer@openvz.org> <1370287804-3481-13-git-send-email-glommer@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , Mel Gorman , Dave Chinner , , , , Michal Hocko , Johannes Weiner , hughd@google.com, Greg Thelen , Dave Chinner To: Glauber Costa Return-path: In-Reply-To: <1370287804-3481-13-git-send-email-glommer@openvz.org> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 3 Jun 2013 23:29:41 +0400 Glauber Costa wrote: > From: Dave Chinner > > Pass the node of the current zone being reclaimed to shrink_slab(), > allowing the shrinker control nodemask to be set appropriately for > node aware shrinkers. Again, some musings on node hotplug would be interesting. > --- a/drivers/staging/android/ashmem.c > +++ b/drivers/staging/android/ashmem.c > @@ -692,6 +692,9 @@ static long ashmem_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > .gfp_mask = GFP_KERNEL, > .nr_to_scan = 0, > }; > + > + nodes_setall(sc.nodes_to_scan); hm, is there some way to do this within the initializer? ie: .nodes_to_scan = magic_goes_here(), Also, it's a bit sad to set bits for not-present and not-online nodes. > ret = ashmem_shrink(&ashmem_shrinker, &sc); > sc.nr_to_scan = ret; > ashmem_shrink(&ashmem_shrinker, &sc); > > ... > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org