From: Kent Overstreet <koverstreet@google.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Jens Axboe <axboe@kernel.dk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free
Date: Thu, 13 Jun 2013 11:33:15 -0700 [thread overview]
Message-ID: <20130613183315.GH10979@localhost> (raw)
In-Reply-To: <CAErSpo7s1m=6WvgeVOQ3Zj=mU8=+13pT4hJ8k5-KkrDDGOU+5w@mail.gmail.com>
On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote:
> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> > This fixes a copy and paste error introduced by 9f060e2231
> > ("block: Convert integrity to bvec_alloc_bs()").
> >
> > Found by Coverity (CID 1020654).
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> > fs/bio-integrity.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> > index 8fb4291..45e944f 100644
> > --- a/fs/bio-integrity.c
> > +++ b/fs/bio-integrity.c
> > @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
> > mempool_destroy(bs->bio_integrity_pool);
> >
> > if (bs->bvec_integrity_pool)
> > - mempool_destroy(bs->bio_integrity_pool);
> > + mempool_destroy(bs->bvec_integrity_pool);
> > }
> > EXPORT_SYMBOL(bioset_integrity_free);
>
> Kent, do you want to chime in on this? Looks like an obvious error to
> me, but maybe I'm missing something and we should teach Coverity to
> shut up about it.
Sorry - no, this is definitely a bug:
Acked-by: Kent Overstreet <koverstreet@google.com>
next prev parent reply other threads:[~2013-06-13 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 22:29 [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free Bjorn Helgaas
2013-06-13 18:14 ` Bjorn Helgaas
2013-06-13 18:33 ` Kent Overstreet [this message]
2013-09-16 13:40 ` Bjorn Helgaas
2013-09-16 13:49 ` Bjorn Helgaas
2013-09-17 18:47 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130613183315.GH10979@localhost \
--to=koverstreet@google.com \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).