From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free Date: Thu, 13 Jun 2013 11:33:15 -0700 Message-ID: <20130613183315.GH10979@localhost> References: <20130529222955.10627.50429.stgit@bhelgaas-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Viro , Jens Axboe , linux-fsdevel , "linux-kernel@vger.kernel.org" , "Martin K. Petersen" To: Bjorn Helgaas Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote: > On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas wrote: > > This fixes a copy and paste error introduced by 9f060e2231 > > ("block: Convert integrity to bvec_alloc_bs()"). > > > > Found by Coverity (CID 1020654). > > > > Signed-off-by: Bjorn Helgaas > > --- > > fs/bio-integrity.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c > > index 8fb4291..45e944f 100644 > > --- a/fs/bio-integrity.c > > +++ b/fs/bio-integrity.c > > @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs) > > mempool_destroy(bs->bio_integrity_pool); > > > > if (bs->bvec_integrity_pool) > > - mempool_destroy(bs->bio_integrity_pool); > > + mempool_destroy(bs->bvec_integrity_pool); > > } > > EXPORT_SYMBOL(bioset_integrity_free); > > Kent, do you want to chime in on this? Looks like an obvious error to > me, but maybe I'm missing something and we should teach Coverity to > shut up about it. Sorry - no, this is definitely a bug: Acked-by: Kent Overstreet