From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH v4 04/12] auto-fs: rename d_count field of dentry to d_refcount Date: Thu, 4 Jul 2013 05:59:56 +0100 Message-ID: <20130704045956.GO4165@ZenIV.linux.org.uk> References: <1372908808-33304-1-git-send-email-Waiman.Long@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Waiman Long , Jeff Layton , Miklos Szeredi , Ingo Molnar , Thomas Gleixner , Ian Kent , autofs mailing list , linux-fsdevel , Linux Kernel Mailing List , Peter Zijlstra , Steven Rostedt , Benjamin Herrenschmidt , Andi Kleen , "Chandramouleeswaran, Aswin" , "Norton, Scott J" To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: autofs-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Jul 03, 2013 at 08:50:07PM -0700, Linus Torvalds wrote: > On Wed, Jul 3, 2013 at 8:33 PM, Waiman Long wrote: > > Because of the d_count name change made in dcache.h, all references > > to d_count have to be changed to d_refcount. There is no change in > > logic and everything should just work. > > These filesystem patches need to be just joined into the same patch > that does the d_count -> d_refcount change. > > Otherwise the kernel won't build in lots of configurations for some > commits, which makes things like bisecting much more painful than it > should be. > > So we can't do piece-meal changes that break the build for parts of the tree. Frankly, my preference here would be to add static inline unsigned d_count(...) and convert the uses of ->d_count outside of fs/{dcache.c,namei.c} and include/linux/dcache.c to it as the first commit. All users outside those are readers, so there's no point playing with macros in this case...