From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 1/4] large-fs: fix large_fs space detection Date: Thu, 11 Jul 2013 10:54:54 +1000 Message-ID: <20130711005454.GT3438@dastard> References: <1373367918-7516-1-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xfs@oss.sgi.com, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, dchinner@redhat.com To: Dmitry Monakhov Return-path: Received: from ipmail04.adl6.internode.on.net ([150.101.137.141]:32928 "EHLO ipmail04.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753256Ab3GKAy5 (ORCPT ); Wed, 10 Jul 2013 20:54:57 -0400 Content-Disposition: inline In-Reply-To: <1373367918-7516-1-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jul 09, 2013 at 03:05:15PM +0400, Dmitry Monakhov wrote: > Currenly large_fs check compare $SCRATCH_DEV_EMPTY_SPACE and $fs_size > which is not correct because total empty size required is $SCRATCH_DEV_EMPTY_SPACE + 50Gb > This path fix space detection, so check becomes valid for all situations. I'm not sure what problem you're fixing from this description? It's takenme a few minutes to work out that: "If SCRATCH_DEV_EMPTY_SPACE + 50GB is larger than the filesystem size being tested, then the configuration being tested is invalid and should fail. Currently we only check that SCRATCH_DEV_EMPTY_SPACE is greater than the the filesystem size. Fix it to check the combined empty space fits in the filesystem being tested." Otherwise the change looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com