From: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
To: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
Subject: Re: [REVIEW][PATCH] vfs: Lock in place mounts from more privileged users
Date: Wed, 24 Jul 2013 15:30:18 +0000 [thread overview]
Message-ID: <20130724153018.GA17960@mail.hallyn.com> (raw)
In-Reply-To: <20130724124933.GA16517-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
Quoting Serge E. Hallyn (serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org):
> Quoting Eric W. Biederman (ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org):
> >
> > Serge does this patch break lxc? I think all should be well but I want
> > to make certain there is not some hidden case where this fundamentaly
> > breaks some functionality.
>
> I haven't yet tried. I'll build and test a kernel today. I'm pretty
> sure all the child's mounts are done after clone, so I *think* the worst
> case will be that the unmounting of put_old after pivot_root() will
> be noisy. Will let you know.
>
> -serge
Just tested it - works fine. Warns about all of the failed umounts.
Acked-by: Serge Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
( Mind you I'm not approving of the idea of hiding mounts as a security
mechanisms, but I know that neither are you :)
thanks,
-serge
next prev parent reply other threads:[~2013-07-24 15:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 18:30 [REVIEW][PATCH] vfs: Lock in place mounts from more privileged users Eric W. Biederman
[not found] ` <877gghruwq.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-07-24 1:15 ` Andy Lutomirski
[not found] ` <CALCETrXXGhVbkG6AnRck+W1kMns5TJuNYAqe_tV44JvWgDoUzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-24 6:50 ` Eric W. Biederman
[not found] ` <87li4wpi2b.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-07-24 12:49 ` Serge E. Hallyn
[not found] ` <20130724124933.GA16517-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2013-07-24 15:30 ` Serge E. Hallyn [this message]
[not found] ` <20130724153018.GA17960-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2013-07-24 16:05 ` Eric W. Biederman
[not found] ` <87ehaolz8v.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2013-07-24 16:49 ` Serge E. Hallyn
2013-07-24 15:46 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724153018.GA17960@mail.hallyn.com \
--to=serge-a9i7lubdfnhqt0dzr+alfa@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).