From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] vfs: try to unblock evpoll if mounted filesystem is RDONLY Date: Thu, 25 Jul 2013 11:33:35 -0400 Message-ID: <20130725153335.GG26107@mtj.dyndns.org> References: <1373248974-3272-1-git-send-email-jason77.wang@gmail.com> <20130723154555.GC18458@mtj.dyndns.org> <20130723214844.GA25333@quack.suse.cz> <51EFA7A8.4010401@canonical.com> <20130724183931.GB27307@quack.suse.cz> <51F09A50.4040805@canonical.com> <20130725100358.GC9388@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Hui Wang , viro@zeniv.linux.org.uk, kay.sievers@vrfy.org, jaxboe@fusionio.com, linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from mail-yh0-f52.google.com ([209.85.213.52]:39574 "EHLO mail-yh0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755609Ab3GYPdl (ORCPT ); Thu, 25 Jul 2013 11:33:41 -0400 Received: by mail-yh0-f52.google.com with SMTP id f11so603366yha.39 for ; Thu, 25 Jul 2013 08:33:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130725100358.GC9388@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hello, Jan. On Thu, Jul 25, 2013 at 12:03:58PM +0200, Jan Kara wrote: > When we are asked to RW mount in case filesystem cannot really do RW, we > return -EROFS instead of silently falling back to RO mount. Userspace > mount(8) command will try again with MS_RDONLY set so things should still > work OK and the problems with eject button would be solved. I'll try to > code that up. Hmmm.... while it is neat, it is very visible to userland and I'm a bit concerned that we might break some obscure tool which isn't using the standard mount. Not sure about udf but for iso9660, which is vastly more common anyway, just always setting MS_RDONLY seems like the better solution. Thanks. -- tejun