question about splice

question about splice

[majianpeng]

Hi all,
	I used splice and found a prolem(at least i call).
The demo is:
A:splice(regularfileA--->pipe);
B:splice(pipe--->regularfileB)
Before do B, we modify the data of regA which now in pipe. The data to regularfileB willbe change.
If we used the buff
A:read(regA, buff);
B: write(buff, regB);
After A, the contend of regA can't effect the buff.
Review the code of splice,I know the pipe share the pagecache of regA.
Maybe this is not a problem or am i missing something?

Thanks!
Jianpeng Ma

Re: question about splice

[Gu Zheng]

Hi Jianpeng,

On 07/26/2013 03:08 PM, majianpeng wrote:

> Hi all,
> 	I used splice and found a prolem(at least i call).
> The demo is:
> A:splice(regularfileA--->pipe);
> B:splice(pipe--->regularfileB)
> Before do B, we modify the data of regA which now in pipe. The data to regularfileB willbe change.
> If we used the buff
> A:read(regA, buff);
> B: write(buff, regB);
> After A, the contend of regA can't effect the buff.
> Review the code of splice,I know the pipe share the pagecache of regA.

Right. And also this is the splice's original design intention, using share mmap rather
than copy_to_user/copy_from_user in order to achieve zero-copy.

Thanks,
Gu

> Maybe this is not a problem or am i missing something?

> 
> Thanks!
> Jianpeng MaN嫥叉靣笡y氊b瞂千v豝�)藓{.n�+壏{睉赙zXФ\x17洝塄}财爖�&j:+v墾�\a珣赙zZ+€�+zf＂穐殘啳嗃i�z�\x1e畐ア�?櫒璀�&�)撷^[f旟^j谦y呩@A玜囤\x7f�\f0鹅h�\x0f鍜i\x7f


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Re: question about splice

[majianpeng]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2006 bytes --]

>Hi Jianpeng,
>
>On 07/26/2013 03:08 PM, majianpeng wrote:
>
>> Hi all,
>> 	I used splice and found a prolem(at least i call).
>> The demo is:
>> A:splice(regularfileA--->pipe);
>> B:splice(pipe--->regularfileB)
>> Before do B, we modify the data of regA which now in pipe. The data to regularfileB willbe change.
>> If we used the buff
>> A:read(regA, buff);
>> B: write(buff, regB);
>> After A, the contend of regA can't effect the buff.
>> Review the code of splice,I know the pipe share the pagecache of regA.
>
>Right. And also this is the splice's original design intention, using share mmap rather
>than copy_to_user/copy_from_user in order to achieve zero-copy.
>
If it use some method like COW, i think it can avoid this problem.
>Thanks,
>Gu
>
>> Maybe this is not a problem or am i missing something?
>
>> 
>> Thanks!
>> Jianpeng MaN‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^?)Þº{.n?+‰·¥Š{±‘êçzX§¶\x17›¡Ü¨}©ž²Æ z?&j:+v‰¨?\a«‘êçzZ+€?+zf£¢·hšˆ§~†­†Ûi?ûàz?\x1e®w¥¢??™¨è­?&?)ߢ^[f”ù^jÇ«y§m…á@A«a¶Ú\x7f?
>0¶ìh?\x0få’i\x7f
>
>
Thanks!
Jianpeng Ma
>Hi Jianpeng,
>
>On 07/26/2013 03:08 PM, majianpeng wrote:
>
>> Hi all,
>> 	I used splice and found a prolem(at least i call).
>> The demo is:
>> A:splice(regularfileA--->pipe);
>> B:splice(pipe--->regularfileB)
>> Before do B, we modify the data of regA which now in pipe. The data to regularfileB willbe change.
>> If we used the buff
>> A:read(regA, buff);
>> B: write(buff, regB);
>> After A, the contend of regA can't effect the buff.
>> Review the code of splice,I know the pipe share the pagecache of regA.
>
>Right. And also this is the splice's original design intention, using share mmap rather
>than copy_to_user/copy_from_user in order to achieve zero-copy.
>
>Thanks,
>Gu
>
>> Maybe this is not a problem or am i missing something?
>
>> 
>> Thanks!
>> Jianpeng MaN‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^?)Þº{.n?+‰·¥Š{±‘êçzX§¶\x17›¡Ü¨}©ž²Æ z?&j:+v‰¨?\a«‘êçzZ+€?+zf£¢·hšˆ§~†­†Ûi?ûàz?\x1e®w¥¢??™¨è­?&?)ߢ^[f”ù^jÇ«y§m…á@A«a¶Ú\x7f?
>0¶ìh?\x0få’i\x7f
>
>