* [patch] fs/binfmts: double unlock in search_binary_handler()
@ 2013-08-01 15:47 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-08-01 15:47 UTC (permalink / raw)
To: Zach Levis, Andrew Morton; +Cc: linux-fsdevel, Alexander Viro, kernel-janitors
The recent -mm patch 3046d15088 "fs/binfmts: better handling of binfmt
loops" introduced a new "continue" to the loop. The problem is that we
are supposed to be holding the lock at the start so we need to take it
again.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static checker stuff. Untested.
diff --git a/fs/exec.c b/fs/exec.c
index f8b7ed1..e2785fc 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1426,6 +1426,7 @@ int search_binary_handler(struct linux_binprm *bprm)
copy_strings(bprm->argc_orig, *((struct user_arg_ptr *) bprm->argv_orig), bprm);
bprm->argc = bprm->argc_orig;
retval = -ENOEXEC;
+ read_lock(&binfmt_lock);
continue;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-08-01 15:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-01 15:47 [patch] fs/binfmts: double unlock in search_binary_handler() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).