From: Jan Kara <jack@suse.cz>
To: Rich Johnston <rjohnston@sgi.com>
Cc: Jan Kara <jack@suse.cz>,
Chandra Seetharaman <sekharan@us.ibm.com>,
Abhijith Das <adas@redhat.com>,
xfs@oss.sgi.com, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH 1/3] quota: Add a new quotactl command Q_XGETQSTATV
Date: Tue, 13 Aug 2013 23:22:42 +0200 [thread overview]
Message-ID: <20130813212242.GA9158@quack.suse.cz> (raw)
In-Reply-To: <520A9A2F.5090009@sgi.com>
Hi,
Neither me nor linux-fsdevel has been CCed on this change. Please do that
next time. Now looking into the patch in xfs mailing list archive I have
one comment: You declare:
struct fs_quota_statv {
__s8 qs_version; /* version for future changes */
__u8 qs_pad1; /* pad for 16bit alignment */
__u16 qs_flags; /* FS_QUOTA_.* flags */
__u32 qs_incoredqs; /* number of dquots incore */
struct fs_qfilestatv qs_uquota; /* user quota information */
struct fs_qfilestatv qs_gquota; /* group quota information */
struct fs_qfilestatv qs_pquota; /* project quota information */
__s32 qs_btimelimit; /* limit for blks timer */
__s32 qs_itimelimit; /* limit for inodes timer */
__s32 qs_rtbtimelimit;/* limit for rt blks timer */
__u16 qs_bwarnlimit; /* limit for num warnings */
__u16 qs_iwarnlimit; /* limit for num warnings */
__u64 qs_pad2[8]; /* for future proofing */
};
Now do you really need qs_pad2 field? Since the structure is properly
versioned now, even its size can vary between versions, cannot it?
Otherwise the patch looks fine.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-13 21:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 22:27 [PATCH 0/3] Add a new quotactl command to support 3 quota types in XFS Chandra Seetharaman
2013-08-06 22:27 ` [PATCH 1/3] quota: Add a new quotactl command Q_XGETQSTATV Chandra Seetharaman
2013-08-13 20:42 ` Rich Johnston
2013-08-13 20:50 ` Chandra Seetharaman
2013-08-13 21:22 ` Jan Kara [this message]
2013-08-13 22:22 ` Rich Johnston
2013-08-13 22:39 ` Chandra Seetharaman
2013-08-14 9:31 ` Jan Kara
2013-08-21 6:43 ` Christoph Hellwig
2013-08-21 13:01 ` Jan Kara
2013-08-21 18:12 ` Ben Myers
2013-08-21 18:19 ` Christoph Hellwig
2013-08-21 21:15 ` Chandra Seetharaman
2013-08-29 17:00 ` Chandra Seetharaman
2013-08-29 17:48 ` Ben Myers
2013-08-06 22:27 ` [PATCH 2/3] xfs: Add support for the Q_XGETQSTATV Chandra Seetharaman
2013-08-13 20:42 ` Rich Johnston
2013-08-06 22:27 ` [PATCH 3/3] gfs2: " Chandra Seetharaman
2013-08-13 20:42 ` Rich Johnston
2013-08-20 22:25 ` [PATCH 0/3] Add a new quotactl command to support 3 quota types in XFS Ben Myers
2013-08-21 12:28 ` Steven Whitehouse
2013-08-21 17:44 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813212242.GA9158@quack.suse.cz \
--to=jack@suse.cz \
--cc=adas@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rjohnston@sgi.com \
--cc=sekharan@us.ibm.com \
--cc=swhiteho@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).