From: Jan Kara <jack@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>, Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Paul Taysom <taysom@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] writeback: Fix occasional slow sync(1)
Date: Fri, 16 Aug 2013 14:21:29 +0200 [thread overview]
Message-ID: <20130816122129.GA22909@quack.suse.cz> (raw)
In-Reply-To: <20130815151504.87263764989e707c37b70143@linux-foundation.org>
On Thu 15-08-13 15:15:04, Andrew Morton wrote:
> On Mon, 15 Jul 2013 11:45:14 +0200 Jan Kara <jack@suse.cz> wrote:
>
> > In case when system contains no dirty pages, wakeup_flusher_threads()
> > will submit WB_SYNC_NONE writeback for 0 pages so wb_writeback() exits
> > immediately without doing anything. Thus sync(1) will write all the
> > dirty inodes from a WB_SYNC_ALL writeback pass which is slow.
> >
> > Fix the problem by using get_nr_dirty_pages() in
> > wakeup_flusher_threads() instead of calculating number of dirty pages
> > manually. That function also takes number of dirty inodes into account.
>
> Fair enough.
>
> > CC: stable@vger.kernel.org
>
> Unexpected. What was your thinking here?
Right, probably the problem isn't serious enough. Just discard the CC
please. Thanks!
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2013-08-16 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 9:45 [PATCH] writeback: Fix occasional slow sync(1) Jan Kara
2013-07-23 16:16 ` Jan Kara
2013-08-15 22:15 ` Andrew Morton
2013-08-16 12:21 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816122129.GA22909@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=taysom@google.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).