From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: vfs: Don't copy mount bind mounts of /proc/<pid>/ns/mnt between
 namespaces
Date: Mon, 2 Sep 2013 23:40:38 +0300
Message-ID: <20130902204038.GO19256@mwanda>
References: <20130902140531.GA5450@elgon.mountain>
 <874na3nf07.fsf@xmission.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: "Eric W. Biederman" <ebiederm@xmission.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from aserp1040.oracle.com ([141.146.126.69]:23283 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758901Ab3IBUkt (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 2 Sep 2013 16:40:49 -0400
Content-Disposition: inline
In-Reply-To: <874na3nf07.fsf@xmission.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Sep 02, 2013 at 01:30:00PM -0700, Eric W. Biederman wrote:
> Dan Carpenter <dan.carpenter@oracle.com> writes:
> 
> > Hello Eric W. Biederman,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 4ce5d2b1a8fd: "vfs: Don't copy mount bind mounts of
> > /proc/<pid>/ns/mnt between namespaces" from Mar 30, 2013, leads to
> > the following Smatch complaint:
> 
> Semi-autoautomatic reply.  The test !q is enough to ensure p is valid
> until p->mnt.mnt_root == q->mnt.mnt_root.
> 
> This has been verified through both testing and reading of the code.
> 

Why not make the test:

	while (1) { ...

regards,
dan carpenter