From: Jeff Layton <jlayton@redhat.com>
To: Ian Kent <raven@themaw.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
rui.xiang@huawei.com,
autofs mailing list <autofs@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/3] autofs4 - fix device ioctl mount lookup
Date: Fri, 6 Sep 2013 06:11:13 -0400 [thread overview]
Message-ID: <20130906061113.18638eb0@corrin.poochiereds.net> (raw)
In-Reply-To: <1378457659.2311.23.camel@perseus.fritz.box>
On Fri, 06 Sep 2013 16:54:19 +0800
Ian Kent <raven@themaw.net> wrote:
>
> Sorry, I should have added Jeff to the cc for this post.
>
> On Fri, 2013-09-06 at 16:38 +0800, Ian Kent wrote:
> > On Wed, 2013-09-04 at 03:42 +0100, Al Viro wrote:
> > > On Wed, Sep 04, 2013 at 03:26:17AM +0100, Al Viro wrote:
> > > > I've applied slightly modified variant of Jeff's "vfs: allow umount to handle
> > > > mountpoints without revalidating them" (modified by just leaving the
> > > > struct path filled with mountpoint and leaving the equivalent of follow_mount()
> > > > to caller) to the local queue and I'm pretty sure that it's what we want
> > > > here as well.
> > >
> > > ... and killed the modifications since the result ends up uglier for
> > > caller(s) anyway. Reapplied as-is.
> >
> > Looks like Jeff's patch has been merged, commit 8033426e6.
> >
> > Revalidation isn't the only thing not done on the last component using
> > Jeff's user_path_umountat() path walk. It also bypasses the managed
> > dentry code for the last component, which is why it's what I need as
> > well.
> >
> > Encoding umount in the name seems misleading as to what it really does
> > as would encoding unmanaged or similar since that doesn't properly cover
> > it either.
> >
> > I can rename it in a patch to solve my autofs problem, so how about
> > something like user_path_simple_last(), other suggestions anyone?
> >
> > Ian
>
>
Since the purpose is to find mountpoints, maybe user_path_mntpoint()?
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2013-09-06 10:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 0:54 [PATCH 1/3] autofs4 - fix device ioctl mount lookup Ian Kent
2013-09-04 0:55 ` [PATCH 2/3] autofs: fix the return value of autofs4_fill_super Ian Kent
2013-09-04 0:55 ` [PATCH 3/3] autofs: use IS_ROOT to replace root dentry checks Ian Kent
2013-09-04 1:03 ` [PATCH 1/3] autofs4 - fix device ioctl mount lookup Al Viro
2013-09-04 2:00 ` Al Viro
2013-09-04 2:18 ` Linus Torvalds
2013-09-04 2:26 ` Al Viro
2013-09-04 2:42 ` Al Viro
2013-09-04 3:53 ` Ian Kent
2013-09-04 4:07 ` Ian Kent
2013-09-04 10:35 ` Jeff Layton
2013-09-06 8:38 ` Ian Kent
2013-09-06 8:54 ` Ian Kent
2013-09-06 10:11 ` Jeff Layton [this message]
2013-09-04 2:46 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906061113.18638eb0@corrin.poochiereds.net \
--to=jlayton@redhat.com \
--cc=autofs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=rui.xiang@huawei.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).