From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/3] dcache: use IS_ROOT to decide where dentry is hashed Date: Fri, 6 Sep 2013 10:00:44 -0700 Message-ID: <20130906170044.GA6460@infradead.org> References: <1378482230-16312-1-git-send-email-bfields@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Nick Piggin To: "J. Bruce Fields" Return-path: Content-Disposition: inline In-Reply-To: <1378482230-16312-1-git-send-email-bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Sep 06, 2013 at 11:43:48AM -0400, J. Bruce Fields wrote: > diff --git a/fs/dcache.c b/fs/dcache.c > index b949af8..934f02d 100644 > --- a/fs/dcache.c > +++ b/fs/dcache.c > @@ -393,7 +393,7 @@ static void __d_shrink(struct dentry *dentry) > { > if (!d_unhashed(dentry)) { > struct hlist_bl_head *b; > - if (unlikely(dentry->d_flags & DCACHE_DISCONNECTED)) > + if (unlikely(IS_ROOT(dentry))) I think this needs a comment about why the IS_ROOT check is fine, destilled from your commit log. Also while reviewing this I noticed that one of the two callers of __d_shrink already has the d_unhashed check - it might make sense to move it to the other caller as well if you touch this area anyway. (as a separate patch). -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html