From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Andrew Pinski <apinski@cavium.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 3/5] FS: Export poll_select_copy_remaining and rename poll_select_copy_remaining in compat.c so it does not pick the wrong copy.
Date: Wed, 11 Sep 2013 12:09:01 +0100 [thread overview]
Message-ID: <20130911110901.GD26777@darko.cambridge.arm.com> (raw)
In-Reply-To: <1378762380-13152-3-git-send-email-apinski@cavium.com>
On Mon, Sep 09, 2013 at 10:32:57PM +0100, Andrew Pinski wrote:
> The ILP32 ABI in ARM64 uses a slightly different pselect from either
> the compat or even the native LP64 ABI. We would want to reuse some
> of the code path that are used as the size of the timespec is the
> same, so this patch exports poll_select_copy_remaining from
> fs/select.c and renames the copy in fs/compat.c to make sure that it
> is not being used.
>
> Signed-off-by: Andrew Pinski <apinski@cavium.com>
I think this patch has to wait until we review the ILP32 ABI for arm64.
When I looked at this some time ago I thought we can just use the native
arm64 pselect6 and ppoll. Once we agree that's not possible we can push
this patch. On its own it doesn't have much value.
--
Catalin
next prev parent reply other threads:[~2013-09-11 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1378762380-13152-1-git-send-email-apinski@cavium.com>
2013-09-09 21:32 ` [PATCH 3/5] FS: Export poll_select_copy_remaining and rename poll_select_copy_remaining in compat.c so it does not pick the wrong copy Andrew Pinski
2013-09-09 21:32 ` Andrew Pinski
2013-09-11 11:09 ` Catalin Marinas [this message]
2013-09-11 21:00 ` Andrew Pinski
2013-09-13 9:53 ` Catalin Marinas
2013-09-09 21:32 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130911110901.GD26777@darko.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=apinski@cavium.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pinskia@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).