* [TRIVIAL PATCH] fs-writeback: Replace sb->s_type->name with sb->s_id to get name of super_block.
@ 2013-09-13 2:58 majianpeng
2013-10-08 22:48 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: majianpeng @ 2013-09-13 2:58 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
fs/fs-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 30f6f27..464b9c8 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -69,7 +69,7 @@ static inline struct backing_dev_info *inode_to_bdi(struct inode *inode)
{
struct super_block *sb = inode->i_sb;
- if (strcmp(sb->s_type->name, "bdev") == 0)
+ if (strcmp(sb->s_id, "bdev") == 0)
return inode->i_mapping->backing_dev_info;
return sb->s_bdi;
--
1.8.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [TRIVIAL PATCH] fs-writeback: Replace sb->s_type->name with sb->s_id to get name of super_block.
2013-09-13 2:58 [TRIVIAL PATCH] fs-writeback: Replace sb->s_type->name with sb->s_id to get name of super_block majianpeng
@ 2013-10-08 22:48 ` Andrew Morton
2013-10-08 22:50 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2013-10-08 22:48 UTC (permalink / raw)
To: majianpeng; +Cc: viro, linux-fsdevel
On Fri, 13 Sep 2013 10:58:23 +0800 majianpeng <majianpeng@gmail.com> wrote:
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> ---
> fs/fs-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 30f6f27..464b9c8 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -69,7 +69,7 @@ static inline struct backing_dev_info *inode_to_bdi(struct inode *inode)
> {
> struct super_block *sb = inode->i_sb;
>
> - if (strcmp(sb->s_type->name, "bdev") == 0)
> + if (strcmp(sb->s_id, "bdev") == 0)
> return inode->i_mapping->backing_dev_info;
>
> return sb->s_bdi;
inode_to_bdi() doesn't exist any more, but similar code exists in the
remarkably named block_dump___mark_inode_dirty().
Using strcmp() is nasty. Can't we use sb_is_blkdev_sb() in there?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [TRIVIAL PATCH] fs-writeback: Replace sb->s_type->name with sb->s_id to get name of super_block.
2013-10-08 22:48 ` Andrew Morton
@ 2013-10-08 22:50 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2013-10-08 22:50 UTC (permalink / raw)
To: majianpeng, viro, linux-fsdevel
On Tue, 8 Oct 2013 15:48:53 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
> On Fri, 13 Sep 2013 10:58:23 +0800 majianpeng <majianpeng@gmail.com> wrote:
>
> > Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> > ---
> > fs/fs-writeback.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> > index 30f6f27..464b9c8 100644
> > --- a/fs/fs-writeback.c
> > +++ b/fs/fs-writeback.c
> > @@ -69,7 +69,7 @@ static inline struct backing_dev_info *inode_to_bdi(struct inode *inode)
> > {
> > struct super_block *sb = inode->i_sb;
> >
> > - if (strcmp(sb->s_type->name, "bdev") == 0)
> > + if (strcmp(sb->s_id, "bdev") == 0)
> > return inode->i_mapping->backing_dev_info;
> >
> > return sb->s_bdi;
>
> inode_to_bdi() doesn't exist any more
err, actually it does exist, but has already been converted to use
sb_is_blkdev_sb().
> but similar code exists in the
> remarkably named block_dump___mark_inode_dirty().
>
> Using strcmp() is nasty. Can't we use sb_is_blkdev_sb() in there?
This.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-08 22:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13 2:58 [TRIVIAL PATCH] fs-writeback: Replace sb->s_type->name with sb->s_id to get name of super_block majianpeng
2013-10-08 22:48 ` Andrew Morton
2013-10-08 22:50 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).