From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 02/11] 9p: fix dentry leak in v9fs_vfs_atomic_open_dotl()
Date: Mon, 16 Sep 2013 19:19:38 +0100
Message-ID: <20130916181938.GD13318@ZenIV.linux.org.uk>
References: <1379335925-30858-1-git-send-email-miklos@szeredi.hu>
 <1379335925-30858-3-git-send-email-miklos@szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	mszeredi@suse.cz, Eric Van Hensbergen <ericvh@gmail.com>,
	"M. Mohan Kumar" <mohan@in.ibm.com>, stable@vger.kernel.org
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:56064 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751353Ab3IPSTm (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 16 Sep 2013 14:19:42 -0400
Content-Disposition: inline
In-Reply-To: <1379335925-30858-3-git-send-email-miklos@szeredi.hu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Sep 16, 2013 at 02:51:56PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
> 
> commit b6f4bee02f "fs/9p: Fix atomic_open" fixed the O_EXCL behavior, but
> results in a dentry leak if v9fs_vfs_lookup() returns non-NULL.

Frankly, I would prefer to deal with that in fs/namei.c:atomic_open()
instead.  I.e. let it call finish_no_open() as it used to do and
turn
                if (create_error && dentry->d_inode == NULL) {
                        error = create_error;
                        goto out;
                }
in fs/namei.c:atomic_open() into
		if (!dentry->d_inode) {
			if (create_error) {
				error = create_error;
				goto out;
			}
		} else if ((open_flag & (O_CREAT | O_EXCL)) == (O_CREAT | O_EXCL)) {
			error = -EEXIST;
			goto out;
		}

rather than try to deal with that crap in each instance of ->atomic_open()...
Objections?