From: David Howells <dhowells@redhat.com>
To: Trond.Myklebust@netapp.com, steved@redhat.com
Cc: linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-cachefs@redhat.com,
linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org
Subject: [RFC][PATCH 0/3] FS-Cache: NFS(/CIFS/Ceph/9P): Fix start-caching whilst writing race
Date: Fri, 20 Sep 2013 16:09:03 +0100 [thread overview]
Message-ID: <20130920150902.16220.32737.stgit@warthog.procyon.org.uk> (raw)
Following this mail is a series of patches to fix an issue with NFS whereby
caching can be enabled on a file that is open for writing by subsequently
opening it for reading. This can be made to crash by opening it for writing
again if you're quick enough.
The patches mailed here may not apply directly. They are based on top of three
fix patches as can be seen in the GIT branch here:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache
The gist of the patchset is that the cookie should be acquired at inode
creation only and subsequently enabled and disabled as appropriate (which
dispenses with the backing objects when they're not needed).
The extra synchronisation that NFS does can then be dispensed with as it is
thenceforth managed by FS-Cache.
This likely will need applying to CIFS, Ceph and 9P also once this is okayed
for NFS. AFS is probably safe.
David
---
David Howells (3):
FS-Cache: Add use/unuse/wake cookie wrappers
FS-Cache: Provide the ability to enable/disable cookies
NFS: Use i_writecount to control whether to get an fscache cookie in nfs_open()
Documentation/filesystems/caching/netfs-api.txt | 73 +++++++--
fs/9p/cache.c | 6 -
fs/afs/cell.c | 2
fs/afs/inode.c | 2
fs/afs/vlocation.c | 3
fs/afs/volume.c | 2
fs/cachefiles/interface.c | 2
fs/ceph/cache.c | 4
fs/cifs/fscache.c | 8 -
fs/fscache/cookie.c | 193 +++++++++++++++++------
fs/fscache/fsdef.c | 1
fs/fscache/netfs.c | 1
fs/fscache/object.c | 7 +
fs/fscache/page.c | 59 +++++--
fs/nfs/dir.c | 2
fs/nfs/fscache.c | 196 +++++++----------------
fs/nfs/fscache.h | 18 +-
fs/nfs/inode.c | 6 -
fs/nfs/nfs4file.c | 2
include/linux/fs.h | 5 +
include/linux/fscache-cache.h | 50 ++----
include/linux/fscache.h | 113 ++++++++++++-
include/linux/nfs_fs.h | 8 +
23 files changed, 462 insertions(+), 301 deletions(-)
next reply other threads:[~2013-09-20 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 15:09 David Howells [this message]
2013-09-20 15:09 ` [PATCH 1/3] FS-Cache: Add use/unuse/wake cookie wrappers David Howells
2013-09-20 15:09 ` [PATCH 2/3] FS-Cache: Provide the ability to enable/disable cookies David Howells
2013-09-20 15:09 ` [PATCH 3/3] NFS: Use i_writecount to control whether to get an fscache cookie in nfs_open() David Howells
[not found] ` <20130920150902.16220.32737.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2013-09-23 17:00 ` [RFC][PATCH 0/3] FS-Cache: NFS(/CIFS/Ceph/9P): Fix start-caching whilst writing race Milosz Tanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920150902.16220.32737.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).