From: Dave Chinner <david@fromorbit.com>
To: majianpeng <majianpeng@gmail.com>
Cc: tj <tj@kernel.org>, axboe <axboe@kernel.dk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RESEND PATCH] writeback: Judge bdi->dev when set worker desc in bdi_writeback_workfn.
Date: Thu, 26 Sep 2013 08:43:51 +1000 [thread overview]
Message-ID: <20130925224351.GJ26872@dastard> (raw)
In-Reply-To: <2013092516084285960311@gmail.com>
On Wed, Sep 25, 2013 at 04:08:54PM +0800, majianpeng wrote:
> Hi,
> How about this patch?
> This bug can easily to reproduce.
> dd if=/dev/zero of=/dev/sdb bs=64k
> For a while, remove the disk. At my machine, it at most 100% occured.
...
> >
> >This bug introduced by commit ef3b101925f2170c.
> >I think the situation is like:
> >remove disk flush_thread_work
> >bdi_destroy()
> > bdi_unregister()
> > bdi->dev = NULL
> > bdi_writeback_workfn()
You're just papering over the larger problem, in that the writeback
work is running concurrently with the bdi_unregister() function that
is tearing the bdi down. You should try to fix the underlying race
condition, as documented in bdi_destroy.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2013-09-25 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 0:11 [RESEND PATCH] writeback: Judge bdi->dev when set worker desc in bdi_writeback_workfn majianpeng
2013-09-25 8:08 ` majianpeng
2013-09-25 22:43 ` Dave Chinner [this message]
2013-09-26 13:35 ` tj
2013-09-26 17:47 ` Christoph Hellwig
2013-09-26 22:59 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925224351.GJ26872@dastard \
--to=david@fromorbit.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=majianpeng@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).