From: Al Viro <viro@ZenIV.linux.org.uk>
To: Namhyung Kim <namhyung@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] vfs: Get rid of duplicate file_ops check in do_readv_writev()
Date: Sun, 29 Sep 2013 23:24:53 +0100 [thread overview]
Message-ID: <20130929222453.GP13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1380447470-2811-2-git-send-email-namhyung@kernel.org>
On Sun, Sep 29, 2013 at 06:37:50PM +0900, Namhyung Kim wrote:
> The file->f_op check in do_readv_writev() is redundant since all of
> its caller (vfs_readv and vfs_writev) already did the check. The
> same goes to compat_do_readv_writev().
... and the right fix is to kill all those checks completely. I have that
done in local queue; will push to #for-next tonight. file->f_op should
never be NULL, period.
prev parent reply other threads:[~2013-09-29 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-29 9:37 [PATCH 1/2] vfs: Get rid of duplicate offset checks in p{read,write}* Namhyung Kim
2013-09-29 9:37 ` [PATCH 2/2] vfs: Get rid of duplicate file_ops check in do_readv_writev() Namhyung Kim
2013-09-29 22:24 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130929222453.GP13318@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).