From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [RFC][PATCH 10/13] make dump_emit() use vfs_write() instead of banging at ->f_op->write directly Date: Wed, 9 Oct 2013 03:06:23 +0100 Message-ID: <20131009020623.GG13318@ZenIV.linux.org.uk> References: <20131009011833.GE13318@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel , Linux Kernel Mailing List To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Oct 08, 2013 at 06:38:47PM -0700, Linus Torvalds wrote: > On Tue, Oct 8, 2013 at 6:18 PM, Al Viro wrote: > > > > Point, but I would argue that we should yell very loud if we get 0 from > > vfs_write() for non-zero size. I'm not sure if POSIX allows write(2) > > to return that, but a lot of userland code won't be expecting that and > > won't be able to cope... > > Actually POSIX very much allows zero returns. O_NDELAY is mentioned as > a possible cause, in addition to zero-sized writes themselves, of > course. Umm... What it says is "If some data can be written without blocking the thread, write() shall write what it can and return the number of bytes written. Otherwise, it shall return -1 and set errno to EAGAIN." For sockets EWOULDBLOCK is also allowed as a possible errno value. I hadn't dug through the streams-related part, but we don't have that mess anyway. > Also, writing to (but not past) the end of a block device returns 0 > for "end of device", iirc. What do you mean? If the starting position is below the end of device, we get a non-zero length write, not exceeding the end. If it's at the end of device, we get -ENOSPC. It's out of scope for POSIX, but Linux is definitely acting that way...