From mboxrd@z Thu Jan 1 00:00:00 1970 From: majianpeng Subject: [PATCH] inode: For readonly filesystem, func file_update_time should return -EROFS rather than zero. Date: Tue, 15 Oct 2013 11:26:00 +0800 Message-ID: <201310151125581359520@gmail.com> Reply-To: majianpeng Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: jbacik , linux-fsdevel , LKML To: viro Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:44121 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755820Ab3JOD0H (ORCPT ); Mon, 14 Oct 2013 23:26:07 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Rm9yIGV4dDIgbW91bnRlZCB3aXRoIGVycm9ycz1yZW1vdW50LXJvLCBpZiB3cml0ZSBhIGZpbGUg YW5kIGJlY2F1c2UgdGhlDQpoYXJkZGlzayBlcnJvciwgdGhlIGZzIGJlY2FtZSByby5CdXQgdGhl IGZvbGxvd2luZyB0ZXN0IGNhbid0IHJldHVybi4NCg0KaW50IG1haW4oKQ0Kew0KCWludCByZXQ7 DQoJaW50IGkgPSAwOw0KCWNoYXIgYnVmZltTSVpFXTsNCglpbnQgZmQgPSBvcGVuKCIvb3B0L3Rl c3QiLCBPX1dST05MWXxPX1RSVU5DfE9fQ1JFQVQpOw0KDQoJaWYgKGZkIDwgMCkgew0KCQlwcmlu dGYoIm9wZW4gZXJyb3IgJXNcbiIsIHN0cmVycm9yKGVycm5vKSk7DQoJCXJldHVybiBlcnJubzsN Cgl9DQoNCglyZXQgPSB3cml0ZShmZCwgYnVmZiwgU0laRSk7DQoJbHNlZWsoZmQsIDAsIDApOw0K DQoJd2hpbGUgKDEpIHsNCgkJcmV0ID0gd3JpdGUoZmQsIGJ1ZmYsIFNJWkUpOw0KCQlpZiAocmV0 IDwgMCkgew0KCQkJcHJpbnRmKCJ3cml0ZSBlcnJvciAlc1xuIiwgc3RyZXJyb3IoZXJybm8pKTsN CgkJCWJyZWFrOw0KCQl9DQoJCWxzZWVrKGZkLCAwLCAwKTsNCgkJaSsrOw0KCX0NCglwcmludGYo IndyaXRlIGNvdW50PSVkXG4iLCBpKTsNCgljbG9zZShmZCk7DQoNCglyZXR1cm4gMDsNCn0NCg0K Rm9yIGV4dDMvZXh0NCwgYmVjYXVzZSBqYmQgdGhlIHRlc3QgY2FuIHJldHVybi4gQnV0IGZvciBl eHQyLCBiZWNhdXNlIG5vDQpqYmQgYW5kIG5vdCByZWFkaW5nIGJpdG1hcCBmcm9tIGhhcmRkaXNr LCB0aGUgdGVzdCBjb250aW51ZS4NCg0KU28gd2Ugc2hvdWxkIGFkZCBjaGVjayByZWFkb25seS1m cyBvbiB3cml0ZS1wYXRoLiBGdW5jIGZpbGVfdXBkYXRlX3RpbWUNCmFscmVhZHkgY2hlY2sgdGhl IHJlYWRvbmx5IGZsYWcsYnV0IGl0IGNhbid0IHJldHVybiAtRVJPRlMuDQpGb3IgcmVhZG9ubHkt ZnMsIGl0IGNhbid0IHVwZGF0ZSBhL2MvbSB0aW1lIG9mIGZpbGUsaXQgc2hvdWxkIHJldHVybg0K LUVST0ZTIHJhdGhlciB0aGFuIHplcm8uDQoNClNpZ25lZC1vZmYtYnk6IEppYW5wZW5nIE1hIDxt YWppYW5wZW5nQGdtYWlsLmNvbT4NCi0tLQ0KIGZzL2lub2RlLmMgfCA1ICsrKy0tDQogMSBmaWxl IGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBh L2ZzL2lub2RlLmMgYi9mcy9pbm9kZS5jDQppbmRleCBiMzNiYThlLi42NTMwMmMxIDEwMDY0NA0K LS0tIGEvZnMvaW5vZGUuYw0KKysrIGIvZnMvaW5vZGUuYw0KQEAgLTE2NDQsOCArMTY0NCw5IEBA IGludCBmaWxlX3VwZGF0ZV90aW1lKHN0cnVjdCBmaWxlICpmaWxlKQ0KIAkJcmV0dXJuIDA7DQog DQogCS8qIEZpbmFsbHkgYWxsb3dlZCB0byB3cml0ZT8gVGFrZXMgbG9jay4gKi8NCi0JaWYgKF9f bW50X3dhbnRfd3JpdGVfZmlsZShmaWxlKSkNCi0JCXJldHVybiAwOw0KKwlyZXQgPSBfX21udF93 YW50X3dyaXRlX2ZpbGUoZmlsZSk7DQorCWlmIChyZXQpDQorCQlyZXR1cm4gcmV0Ow0KIA0KIAly ZXQgPSB1cGRhdGVfdGltZShpbm9kZSwgJm5vdywgc3luY19pdCk7DQogCV9fbW50X2Ryb3Bfd3Jp dGVfZmlsZShmaWxlKTsNCi0tIA0KMS44LjQNCg==