From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/5] exportfs: move most of reconnect_path to helper function Date: Wed, 16 Oct 2013 00:16:48 -0700 Message-ID: <20131016071648.GA28671@infradead.org> References: <1381869574-10662-1-git-send-email-bfields@redhat.com> <1381869574-10662-3-git-send-email-bfields@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , Al Viro , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "J. Bruce Fields" Return-path: Content-Disposition: inline In-Reply-To: <1381869574-10662-3-git-send-email-bfields-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org > /* > + * Return the parent directory on success. > + * > + * Return NULL to keep trying. > + * > + * Otherwise return an error. > + */ > +static int reconnect_one(struct vfsmount *mnt, struct dentry *pd, char *nbuf, int *noprogress) Please keep the lines under 80 characters. > + struct dentry *ppd; > + struct dentry *npd; Might as well use sensible names already when splitting it out instead of renaming them later down the series? Otherwise looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html