linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Stefani Seibold <stefani@seibold.net>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org, mingo@redhat.com,
	peterz@infradead.org
Subject: Re: [PATCH] add new prctl for a per process wide close on exec
Date: Tue, 22 Oct 2013 20:48:37 +0100	[thread overview]
Message-ID: <20131022194836.GZ13318@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1382470038-1220-1-git-send-email-stefani@seibold.net>

On Tue, Oct 22, 2013 at 09:27:18PM +0200, Stefani Seibold wrote:

> This patch will increase security since no developers can review all libraries
> which there are using. Also in a team of developers it is not always possible
> to have a full survey over the code which is produced. Or the output of a code
> generators and so one. This patch allows a kind of preventive measures.
> 
> It can also prevent resource occupation. Imagine a long running process (a
> daemon) is execute from the application after open some file desciptors. For
> example libpcsclite.so will not open the socket with SOCK_CLOEXEC. Or a device
> driver which alows only a single open. In both cases the resource cannot
> reopened after a close. Sigh!
> 
> What do you think?

That it's a bad idea.  Not to mention anything else, the same unreviewed
libraries can get buggered if the program sets that "global close-on-exec"
and it's not at all obvious whether the breakage from that change will be less
or more dangerous than leaking opened files to children.

Al, fully expecting the Linux S-M crowd to jump on that one and come up with
yet another one-shot LSM... ;-/

  reply	other threads:[~2013-10-22 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-22 19:27 [PATCH] add new prctl for a per process wide close on exec Stefani Seibold
2013-10-22 19:48 ` Al Viro [this message]
2013-10-24 11:44   ` Stefani Seibold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131022194836.GZ13318@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=stefani@seibold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).